From ee6e93b24535df911498eb02a4b7827464d87569 Mon Sep 17 00:00:00 2001 From: "Robert P. Goldman" Date: Tue, 21 Jul 2020 15:22:40 -0500 Subject: [PATCH 1/3] Clarify drop_vars return value. The previous documentation was not clear about whether the variable dropping was "inplace" or created a fresh Dataset. --- xarray/core/dataarray.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xarray/core/dataarray.py b/xarray/core/dataarray.py index cbd8d243385..f813aabc517 100644 --- a/xarray/core/dataarray.py +++ b/xarray/core/dataarray.py @@ -1928,7 +1928,7 @@ def T(self) -> "DataArray": def drop_vars( self, names: Union[Hashable, Iterable[Hashable]], *, errors: str = "raise" ) -> "DataArray": - """Drop variables from this DataArray. + """Drop variables from this DataArray. *Not* done inplace. Parameters ---------- @@ -1942,7 +1942,7 @@ def drop_vars( Returns ------- dropped : Dataset - + New Dataset copied from ``self`` with variables removed. """ ds = self._to_temp_dataset().drop_vars(names, errors=errors) return self._from_temp_dataset(ds) From 7a5168d2f4f3907c4257d8cafa1d4d9408a2315c Mon Sep 17 00:00:00 2001 From: rpgoldman Date: Sun, 26 Jul 2020 08:46:44 -0500 Subject: [PATCH 2/3] Update xarray/core/dataarray.py Fix syntax error in docstring markdown. Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com> --- xarray/core/dataarray.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xarray/core/dataarray.py b/xarray/core/dataarray.py index f813aabc517..080dac75525 100644 --- a/xarray/core/dataarray.py +++ b/xarray/core/dataarray.py @@ -1942,7 +1942,7 @@ def drop_vars( Returns ------- dropped : Dataset - New Dataset copied from ``self`` with variables removed. + New Dataset copied from `self` with variables removed. """ ds = self._to_temp_dataset().drop_vars(names, errors=errors) return self._from_temp_dataset(ds) From 5641c359665ec19f6da7b350b6f86f0ae3ec4bb3 Mon Sep 17 00:00:00 2001 From: Deepak Cherian Date: Fri, 14 Aug 2020 15:16:41 +0000 Subject: [PATCH 3/3] Update xarray/core/dataarray.py Co-authored-by: Maximilian Roos <5635139+max-sixty@users.noreply.github.com> --- xarray/core/dataarray.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xarray/core/dataarray.py b/xarray/core/dataarray.py index 080dac75525..42aa547f4cf 100644 --- a/xarray/core/dataarray.py +++ b/xarray/core/dataarray.py @@ -1928,7 +1928,7 @@ def T(self) -> "DataArray": def drop_vars( self, names: Union[Hashable, Iterable[Hashable]], *, errors: str = "raise" ) -> "DataArray": - """Drop variables from this DataArray. *Not* done inplace. + """Returns an array with dropped variables. Parameters ----------