Skip to content

doc: reproducible finalizer order examples #10257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

eagleoflqj
Copy link

These 2 tests pass so stdout won't be printed by default.
Fix an import missing.
Rename tests as test_module is meaningless here.

@nicoddemus
Copy link
Member

nicoddemus commented Aug 31, 2022

Thanks @eagleoflqj!

This should be merged/adapted only after #10252 is merged, because this section in the docs as is, is not generating the expected output.

@nicoddemus nicoddemus mentioned this pull request Aug 31, 2022
@nicoddemus
Copy link
Member

While at it I applied the same fix (passing -s) to #10252. Thanks again!

@nicoddemus
Copy link
Member

Fixed in #10252

@nicoddemus nicoddemus closed this Aug 31, 2022
@eagleoflqj eagleoflqj deleted the doc branch August 31, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants