This repository was archived by the owner on Feb 22, 2020. It is now read-only.
Add temporary file to test the CI configuration #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I want to test the CI before the jam starts, I'm opening a dummy PR that will hopefully trigger a (failing) build.
I've added a "Getting Started" section to the READMe. It was based on the "Getting Started"-section from Code Jam 5, but I've made some small changes, like explicitly mentioning and linking the rules in this section. This makes sure that we don't have to maintain two lists of rules (one in the README and one on our website).
I've added a Code Style and Readability section the README that includes information on the automated build pipeline we'll use to automatically lint their pull requests. This section specifies that `flake8` will be leading in case flake8 disagrees with PEP8.
I've added a section with links to pages with useful information for participants on our website. In addition, I've added a fairly basic section mentioning our sponsors and partner. The bare links should probably be replaced by appropriately sized logos.
I have replaced the bare links to sponsors with logos and changed the wording in the "Userful Information for Participants" section.
I've added Linode to the sponsor section and scaled all the logos accordingly to make them fit horizontally
The Useful Information section was too verbose, creating unnecessary visual noise. I've stripped it down to the bare minimum.
"technlogy", great work, Ves.
To make sure teams can work with their own team directory as the root directory of their project, I've added individual `flake8` files to the team folders.
Since flake8 ignores E226 by default, it's unnecessary to mention it as ignored in the README. To avoid confusion and questions, I've removed the mention of it.
It's unnecessary to specifically ignore E226 as flake8 ignores this error by default. I've removed it from the the flake8 config files in the team directories.
I've removed the ignore for E226 from the azure pipelines configuration file. Flake8 already ignores this error by default, so setting this flag doesn't do anything.
I've added the `--isolated` flag to make flake8 ignore configuration files. This ensures that it will lint with the command line options we've provided, even if teams modify their own `.flake8` configuration file.
lemonsaurus
pushed a commit
that referenced
this pull request
Jan 26, 2020
Create lint and test action
lemonsaurus
pushed a commit
that referenced
this pull request
Jan 26, 2020
lemonsaurus
pushed a commit
that referenced
this pull request
Jan 26, 2020
Adds config load + save for lat/lon from geoip, closes #1
lemonsaurus
pushed a commit
that referenced
this pull request
Jan 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dummy PR meant to test the automatic PR trigger for the linting pipeline