Doesn't compile with Python 3.7 due to tstate changes

[nascheme]

greenlet-tstate.txt

The patch is too simple, will need to have an ifdef with the Python version to switch between the old tstate struct and the new one with exc_state.

[snaury]

Is it going to land in alpha3? I just downloaded alpha2 and there's no exc_state in PyThreadState.

[snaury]

I can't find it in mercurial either: https://hg.python.org/cpython/file/4243df51fe43/Include/pystate.h :-/

Turns out cpython moved to github, and I can see it there. :)

[snaury]

Tracked it to python/cpython#1773. I think I'm going to wait until alpha3 is released (December 4 according to schedule), so I could use PY_VERSION_HEX >= 0x030700A3 as a guard.

[nascheme]

The change is in git commit ae3087c6382011c47db82fea4d05f8bbf514265d.  Oct 22.

[nascheme]

cython uses #if PY_VERSION_HEX >= 0x030700A2.

See cython/cython@8ad16fc as an example. There are a few other places cython accesses the exc_state struct.

[nedbat]

When can we expect a new release with this fix?

[snaury]

Python 3.7 is not released yet, not even a beta or a release candidate, why would you expect me to make a release? I don't follow python news though, so would you please remind me when a release candidate for 3.7 is finally released? I think that would be a good time for the new greenlet release, as possibility for further breaking changes would be minimal.

[nedbat]

I'm trying to run the coverage.py test suite against the 3.7 alpha, to find problems in CPython, and to be ready when 3.7 is released. My test suite fails because it uses greenlet (to be sure that coverage.py works with greenlet).

Could you make an alpha release of greenlet so that I can install it from PyPI?

[snaury]

Since you are testing against alpha, can't you just install a dev version of greenlet from source? Anyway, making a release is a lot of manual work with many opportunities to make a mistake, I would prefer avoiding it as much as possible.

[nedbat]

I can do that, and it works. But it means I have to install cython and choose a random sha from GitHub. It's slow and forces me to make some arbitrary decisions.

[snaury]

But it means I have to install cython

Why would you need that? Greenlet doesn't use nor depend on cython at this time.

and choose a random sha

You could also just use master, the link would be https://github.com/python-greenlet/greenlet/archive/master.zip

[nedbat]

Oops, it's gevent that needs Cython.

[snaury]

Looks like beta1 is finally out, so I just released greenlet 0.4.13.