Always use git clean -fdx (#275)

* Always use git clean -fdx

* Address review: Put common Git/GitHub kwargs in a variable

Author: Erlend Egeberg Aasland

master/master.cfg

@@ -129,6 +129,14 @@ git_branches = [
     # ("https://hg.python.org/buildbot/empty", "3.4", "empty"),
 ]
 
+# common Git() and GitHub() keyword arguments
+GIT_KWDS = {
+    "timeout": 3600,
+    # "git clean -fdx": remove all files which are not tracked by Git,
+    # ignoring the .gitignore rules (ex: remove also ".o" files).
+    "mode": "full",
+    "method": "fresh",
+}
 
 c["builders"] = []
 c["schedulers"] = []
@@ -223,15 +231,7 @@ for branch_num, (git_url, branchname, git_branch) in enumerate(git_branches):
             continue
 
         buildername = name + " " + branchname
-        source = Git(
-            repourl=git_url,
-            branch=git_branch,
-            timeout=3600,
-            # "git clean -fdx": remove all files which are not tracked by Git,
-            # ignoring the .gitignore rules (ex: remove also ".o" files).
-            mode="full",
-            method="fresh",
-        )
+        source = Git(repourl=git_url, branch=git_branch, **GIT_KWDS)
         f = buildfactory(
             source,
             parallel=parallel.get(worker),
@@ -309,7 +309,7 @@ for name, worker, buildfactory, stability in BUILDERS:
 
     pull_request_builders.append(buildername)
 
-    source = GitHub(repourl=git_url, timeout=3600, mode="full", method="clean",)
+    source = GitHub(repourl=git_url, **GIT_KWDS)
 
     f = buildfactory(
         source,