Skip to content

Commit 00a356b

Browse files
committed
address review, style: use f-strings, code cleanup
1 parent 1dc2756 commit 00a356b

File tree

1 file changed

+6
-13
lines changed

1 file changed

+6
-13
lines changed

Tools/clinic/libclinic/parse_args.py

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -470,10 +470,7 @@ def parse_pos_only(self) -> None:
470470
argname_fmt = 'PyTuple_GET_ITEM(args, %d)'
471471

472472
if self.vararg != NO_VARARG:
473-
if self.max_pos == 0:
474-
self.declarations = "Py_ssize_t nvararg = %s;" % nargs
475-
else:
476-
self.declarations = "Py_ssize_t nvararg = Py_MAX(%s - %d, 0);" % (nargs, self.max_pos)
473+
self.declarations = f"Py_ssize_t nvararg = {nargs} - {self.max_pos};"
477474
else:
478475
self.declarations = ""
479476

@@ -525,17 +522,13 @@ def parse_pos_only(self) -> None:
525522
use_parser_code = True
526523
for i, p in enumerate(self.parameters):
527524
if p.is_vararg():
525+
var = p.converter.parser_name
528526
if self.fastcall:
529-
parser_code.append(libclinic.normalize_snippet("""
530-
%s = args + %s;
531-
""" % (
532-
p.converter.parser_name,
533-
self.vararg
534-
), indent=4))
527+
code = f"{var} = args + {self.vararg};"
535528
else:
536-
parser_code.append(libclinic.normalize_snippet("""
537-
%s = _PyTuple_CAST(args)->ob_item;
538-
""" % p.converter.parser_name, indent=4))
529+
code = f"{var} = _PyTuple_CAST(args)->ob_item;"
530+
formatted_code = libclinic.normalize_snippet(code, indent=4)
531+
parser_code.append(formatted_code)
539532
continue
540533

541534
displayname = p.get_displayname(i+1)

0 commit comments

Comments
 (0)