Skip to content

Commit 706385a

Browse files
Refactor: replace query with parameter
Pass state as arg to element_setstate_from_Python()
1 parent 53bd559 commit 706385a

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

Modules/_elementtree.c

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1065,7 +1065,8 @@ element_setstate_from_attributes(elementtreestate *st,
10651065
*/
10661066

10671067
static PyObject *
1068-
element_setstate_from_Python(ElementObject *self, PyObject *state)
1068+
element_setstate_from_Python(elementtreestate *st, ElementObject *self,
1069+
PyObject *state)
10691070
{
10701071
static char *kwlist[] = {PICKLED_TAG, PICKLED_ATTRIB, PICKLED_TEXT,
10711072
PICKLED_TAIL, PICKLED_CHILDREN, 0};
@@ -1078,7 +1079,6 @@ element_setstate_from_Python(ElementObject *self, PyObject *state)
10781079
if (!args)
10791080
return NULL;
10801081

1081-
elementtreestate *st = ET_STATE_GLOBAL;
10821082
if (PyArg_ParseTupleAndKeywords(args, state, "|$OOOOO", kwlist, &tag,
10831083
&attrib, &text, &tail, &children))
10841084
retval = element_setstate_from_attributes(st, self, tag, attrib, text,
@@ -1108,8 +1108,10 @@ _elementtree_Element___setstate__(ElementObject *self, PyObject *state)
11081108
state);
11091109
return NULL;
11101110
}
1111-
else
1112-
return element_setstate_from_Python(self, state);
1111+
else {
1112+
elementtreestate *st = ET_STATE_GLOBAL;
1113+
return element_setstate_from_Python(st, self, state);
1114+
}
11131115
}
11141116

11151117
LOCAL(int)

0 commit comments

Comments
 (0)