Skip to content

Commit 9796fe8

Browse files
bpo-40287: Fix SpooledTemporaryFile.seek() return value (GH-19540)
It has not returned the file position after the seek. (cherry picked from commit 485e715) Co-authored-by: Inada Naoki <[email protected]>
1 parent 6b0ca0a commit 9796fe8

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

Lib/tempfile.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -735,7 +735,7 @@ def readlines(self, *args):
735735
return self._file.readlines(*args)
736736

737737
def seek(self, *args):
738-
self._file.seek(*args)
738+
return self._file.seek(*args)
739739

740740
@property
741741
def softspace(self):

Lib/test/test_tempfile.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,7 +1025,8 @@ def test_writelines(self):
10251025
# Verify writelines with a SpooledTemporaryFile
10261026
f = self.do_create()
10271027
f.writelines((b'x', b'y', b'z'))
1028-
f.seek(0)
1028+
pos = f.seek(0)
1029+
self.assertEqual(pos, 0)
10291030
buf = f.read()
10301031
self.assertEqual(buf, b'xyz')
10311032

@@ -1043,7 +1044,8 @@ def test_sparse(self):
10431044
# when that occurs
10441045
f = self.do_create(max_size=30)
10451046
self.assertFalse(f._rolled)
1046-
f.seek(100, 0)
1047+
pos = f.seek(100, 0)
1048+
self.assertEqual(pos, 100)
10471049
self.assertFalse(f._rolled)
10481050
f.write(b'x')
10491051
self.assertTrue(f._rolled)
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Fixed ``SpooledTemporaryFile.seek()`` to return the position.

0 commit comments

Comments
 (0)