fix TSAN

corona10 · corona10 · commit f573fa237659 · 2024-09-24T21:28:38.000-07:00
diff --git a/Include/internal/pycore_cell.h b/Include/internal/pycore_cell.h
@@ -19,8 +19,8 @@ PyCell_SwapTakeRef(PyCellObject *cell, PyObject *value)
 {
     PyObject *old_value;
     Py_BEGIN_CRITICAL_SECTION(cell);
-    old_value = cell->ob_ref;
-    cell->ob_ref = value;
+    FT_ATOMIC_STORE_PTR_RELAXED(old_value, cell->ob_ref);
+    FT_ATOMIC_STORE_PTR_RELAXED(cell->ob_ref, value);
     Py_END_CRITICAL_SECTION();
     return old_value;
 }

Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,8 @@ PyCell_SwapTakeRef(PyCellObject cell, PyObject value)`
`19`	`19`	`{`
`20`	`20`	`PyObject *old_value;`
`21`	`21`	`Py_BEGIN_CRITICAL_SECTION(cell);`
`22`		`- old_value = cell->ob_ref;`
`23`		`- cell->ob_ref = value;`
	`22`	`+ FT_ATOMIC_STORE_PTR_RELAXED(old_value, cell->ob_ref);`
	`23`	`+ FT_ATOMIC_STORE_PTR_RELAXED(cell->ob_ref, value);`
`24`	`24`	`Py_END_CRITICAL_SECTION();`
`25`	`25`	`return old_value;`
`26`	`26`	`}`