Skip to content

Several unused functions in posixmodule.c under WASI build #120586

@sobolevn

Description

@sobolevn

Bug report

../../Modules/posixmodule.c:7883:1: warning: unused function 'warn_about_fork_with_threads' [-Wunused-function]
../../Modules/posixmodule.c:12545:1: warning: unused function 'major_minor_conv' [-Wunused-function]
../../Modules/posixmodule.c:12556:1: warning: unused function 'major_minor_check' [-Wunused-function]

Link: https://buildbot.python.org/all/#/builders/1046/builds/5439

The problem is that these helpers are defined without a #ifdef guard, while functions that use them have a conditional definition.

I propose to add the same conditions to these functions as well.

Linked PRs

Metadata

Metadata

Assignees

Labels

extension-modulesC modules in the Modules dirtype-bugAn unexpected behavior, bug, or error

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions