-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
Closed
Labels
OS-windowsbuildThe build process and cross-buildThe build process and cross-buildperformancePerformance or resource usagePerformance or resource usagetype-featureA feature request or enhancementA feature request or enhancement
Description
Per suggestion from @zooba in #130040 (comment), don't be too fancy here:
- just support a new optimizing build flag
WITH_COMPUTED_GOTOS
and keepbuild.bat
out of the loop. It does not have to learn such flags. It already knows too many of them "which could just be passed through". - only test for
!= ''
rather than a specific value. - no magic defaults - explicit is better than implicit. If it is there, it's enabled, else it's disabled.
- but document like
set WITH_COMPUTED_GOTOS=true
- this would give us the possibility to opt out using
WITH_COMPUTED_GOTOS=false
, should we ever enable it by default (and the user does not like our guess)
Linked PRs
Metadata
Metadata
Assignees
Labels
OS-windowsbuildThe build process and cross-buildThe build process and cross-buildperformancePerformance or resource usagePerformance or resource usagetype-featureA feature request or enhancementA feature request or enhancement