Skip to content

gh-100600: Fix "coroutine was never awaited" warning in test_coroutines #100601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 29, 2022
Merged

gh-100600: Fix "coroutine was never awaited" warning in test_coroutines #100601

merged 1 commit into from
Dec 29, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Dec 29, 2022 •
edited
Loading

After:

» ./python.exe -m test -v test_coroutines -m test_bpo_45813_2
== CPython 3.12.0a3+ (heads/issue-100577-dirty:43e3659e33, Dec 28 2022, 14:38:55) [Clang 11.0.0 (clang-1100.0.33.16)]
== macOS-10.14.6-x86_64-i386-64bit little-endian
== Python build: debug
== cwd: /Users/sobolev/Desktop/cpython/build/test_python_47299æ
== CPU count: 4
== encodings: locale=UTF-8, FS=utf-8
0:00:00 load avg: 2.26 Run tests sequentially
0:00:00 load avg: 2.26 [1/1] test_coroutines
test_bpo_45813_2 (test.test_coroutines.CoroutineTest.test_bpo_45813_2)
This would crash the interpreter in 3.11a2 ... ok

----------------------------------------------------------------------
Ran 1 test in 0.002s

OK

== Tests result: SUCCESS ==

1 test OK.

Total duration: 402 ms
Tests result: SUCCESS

@bedevere-bot bedevere-bot mentioned this pull request Dec 29, 2022
Closed
@sobolevn sobolevn marked this pull request as ready for review December 29, 2022 07:35
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Dec 29, 2022
@kumaraditya303 kumaraditya303 linked an issue Dec 29, 2022 that may be closed by this pull request
Test test_bpo_45813_2 in test_coroutines generates a "coroutine was never awaited" warning #100600
Closed
@kumaraditya303 kumaraditya303 merged commit 7685636 into python:main Dec 29, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@kumaraditya303
Copy link
Contributor

Thanks!

@bedevere-bot
Copy link

GH-100605 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Dec 29, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 29, 2022
@sobolevn @miss-islington
pythongh-100600: Fix "coroutine was never awaited" warning in `test_c…
2b8c519 
…oroutines` (pythonGH-100601)

(cherry picked from commit 7685636)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington added a commit that referenced this pull request Dec 29, 2022
@miss-islington @sobolevn
gh-100600: Fix "coroutine was never awaited" warning in `test_corouti…
dd520e7 
…nes` (GH-100601)

(cherry picked from commit 7685636)

Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test test_bpo_45813_2 in test_coroutines generates a "coroutine was never awaited" warning
4 participants
@sobolevn @miss-islington @kumaraditya303 @bedevere-bot