gh-117205: Increase chunksize when compiling pyc in parallel #117206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
changed the title
carljm
approved these changes
Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a large, existing venv on my system, running:
python -m compileall -f -j 10 -qq .with warm disk cache and without this change has timings of 41.7s, 42.9s, 42s. With this change, I get timings of 35.7s, 34.9s, 34.6s, for about a 20% speed up. chunksize=2 was a smaller speedup, chunksize=8 was no additional speedup.This seems pretty straightforward, but let me know if you're interested in a more reproducible benchmark or running it on other systems.