Skip to content

gh-120418: Don't assume wheeldata is deleted if WHEEL_PKG_DIR is set #120419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

stefanor
Copy link
Contributor

@stefanor stefanor commented Jun 12, 2024

Remove wheeldata from both sides of the assertEqual, so that we're actually ignoring it from the test set.

This test is only making assertions about the source tree, no code is being executed that would do anything different based on the value of WHEEL_PKG_DIR.

@vstinner
Copy link
Member

cc @sobolevn @hroncok

@stefanor stefanor force-pushed the test-makefile-wheeldata branch from 7b152d2 to b38ac70 Compare June 12, 2024 16:56
… is set

Remove wheeldata from both sides of the `assertEqual`, so that we're
*actually* ignoring it from the test set.

This test is only making assertions about the source tree, no code is
being executed that would do anything different based on the value of
`WHEEL_PKG_DIR`.
@stefanor stefanor force-pushed the test-makefile-wheeldata branch from b38ac70 to f9826d9 Compare June 12, 2024 17:16
@sobolevn sobolevn added skip news needs backport to 3.13 bugs and security fixes labels Jun 12, 2024
@vstinner vstinner merged commit 030b452 into python:main Jun 12, 2024
35 checks passed
@miss-islington-app
Copy link

Thanks @stefanor for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 12, 2024
… is set (pythonGH-120419)

Remove wheeldata from both sides of the `assertEqual`, so that we're
*actually* ignoring it from the test set.

This test is only making assertions about the source tree, no code is
being executed that would do anything different based on the value of
`WHEEL_PKG_DIR`.
(cherry picked from commit 030b452)

Co-authored-by: Stefano Rivera <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Jun 12, 2024

GH-120432 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 12, 2024
vstinner pushed a commit that referenced this pull request Jun 12, 2024
…` is set (GH-120419) (#120432)

gh-120418: Don't assume wheeldata is deleted if `WHEEL_PKG_DIR` is set (GH-120419)

Remove wheeldata from both sides of the `assertEqual`, so that we're
*actually* ignoring it from the test set.

This test is only making assertions about the source tree, no code is
being executed that would do anything different based on the value of
`WHEEL_PKG_DIR`.
(cherry picked from commit 030b452)

Co-authored-by: Stefano Rivera <[email protected]>
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
… is set (python#120419)

Remove wheeldata from both sides of the `assertEqual`, so that we're
*actually* ignoring it from the test set.

This test is only making assertions about the source tree, no code is
being executed that would do anything different based on the value of
`WHEEL_PKG_DIR`.
@stefanor stefanor deleted the test-makefile-wheeldata branch July 1, 2024 17:07
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
… is set (python#120419)

Remove wheeldata from both sides of the `assertEqual`, so that we're
*actually* ignoring it from the test set.

This test is only making assertions about the source tree, no code is
being executed that would do anything different based on the value of
`WHEEL_PKG_DIR`.
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
… is set (python#120419)

Remove wheeldata from both sides of the `assertEqual`, so that we're
*actually* ignoring it from the test set.

This test is only making assertions about the source tree, no code is
being executed that would do anything different based on the value of
`WHEEL_PKG_DIR`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants