From b74a5aa1b441542ddf896b8f462ca1170c95fecc Mon Sep 17 00:00:00 2001 From: Beomsoo Kim Date: Tue, 3 Dec 2024 22:50:40 +0900 Subject: [PATCH 1/3] Removes unnecessary comment --- Lib/_pydatetime.py | 1 - 1 file changed, 1 deletion(-) diff --git a/Lib/_pydatetime.py b/Lib/_pydatetime.py index ed01670cfece43..be90c9b1315d53 100644 --- a/Lib/_pydatetime.py +++ b/Lib/_pydatetime.py @@ -2392,7 +2392,6 @@ def __reduce__(self): def _isoweek1monday(year): # Helper to calculate the day number of the Monday starting week 1 - # XXX This could be done more efficiently THURSDAY = 3 firstday = _ymd2ord(year, 1, 1) firstweekday = (firstday + 6) % 7 # See weekday() above From 604f61a04646e6fc1d7350faecd23783d15e7b00 Mon Sep 17 00:00:00 2001 From: Beomsoo Kim Date: Tue, 3 Dec 2024 22:51:16 +0900 Subject: [PATCH 2/3] Adds a comment about the need for week addition --- Lib/_pydatetime.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Lib/_pydatetime.py b/Lib/_pydatetime.py index be90c9b1315d53..5a1bf5b2b3a24c 100644 --- a/Lib/_pydatetime.py +++ b/Lib/_pydatetime.py @@ -2395,6 +2395,8 @@ def _isoweek1monday(year): THURSDAY = 3 firstday = _ymd2ord(year, 1, 1) firstweekday = (firstday + 6) % 7 # See weekday() above + # If the first weekday is after Thursday, + # ISO week 1 doesn't start until the next Monday week1monday = firstday - firstweekday if firstweekday > THURSDAY: week1monday += 7 From e0cad5fedc39b4467c68fc6e6b524abe4e76cd8e Mon Sep 17 00:00:00 2001 From: Beomsoo Kim Date: Wed, 4 Dec 2024 12:26:22 +0900 Subject: [PATCH 3/3] Revert "Adds a comment about the need for week addition" This reverts commit 604f61a04646e6fc1d7350faecd23783d15e7b00. --- Lib/_pydatetime.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/Lib/_pydatetime.py b/Lib/_pydatetime.py index 5a1bf5b2b3a24c..be90c9b1315d53 100644 --- a/Lib/_pydatetime.py +++ b/Lib/_pydatetime.py @@ -2395,8 +2395,6 @@ def _isoweek1monday(year): THURSDAY = 3 firstday = _ymd2ord(year, 1, 1) firstweekday = (firstday + 6) % 7 # See weekday() above - # If the first weekday is after Thursday, - # ISO week 1 doesn't start until the next Monday week1monday = firstday - firstweekday if firstweekday > THURSDAY: week1monday += 7