From 075cfe00a2bb04ddda0cfbaec51b44850c48657c Mon Sep 17 00:00:00 2001 From: Victor Stinner Date: Mon, 16 Dec 2024 17:38:13 +0100 Subject: [PATCH] gh-127906: Skip limited C API test_cext tests if Py_TRACE_REFS Skip limited C API tests in test_cext and test_cppext if Python is configured with --with-trace-refs (if the Py_TRACE_REFS macro is defined). --- Lib/test/test_cext/__init__.py | 5 +++++ Lib/test/test_cppext/__init__.py | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/Lib/test/test_cext/__init__.py b/Lib/test/test_cext/__init__.py index 9c6d98072481dd..d5ea1dc66035b1 100644 --- a/Lib/test/test_cext/__init__.py +++ b/Lib/test/test_cext/__init__.py @@ -8,12 +8,14 @@ import shlex import shutil import subprocess +import sys import unittest from test import support SOURCE = os.path.join(os.path.dirname(__file__), 'extension.c') SETUP = os.path.join(os.path.dirname(__file__), 'setup.py') +Py_TRACE_REFS = hasattr(sys, 'getobjects') # With MSVC on a debug build, the linker fails with: cannot open file @@ -47,6 +49,9 @@ def test_build_limited_c11(self): self.check_build('_test_limited_c11_cext', limited=True, std='c11') def check_build(self, extension_name, std=None, limited=False): + if limited and Py_TRACE_REFS: + self.skipTest('Py_LIMITED_API is incompatible with Py_TRACE_REFS') + venv_dir = 'env' with support.setup_venv_with_pip_setuptools_wheel(venv_dir) as python_exe: self._check_build(extension_name, python_exe, diff --git a/Lib/test/test_cppext/__init__.py b/Lib/test/test_cppext/__init__.py index cbd062adb32204..2198b7b2c0ba42 100644 --- a/Lib/test/test_cppext/__init__.py +++ b/Lib/test/test_cppext/__init__.py @@ -4,12 +4,14 @@ import shlex import shutil import subprocess +import sys import unittest from test import support SOURCE = os.path.join(os.path.dirname(__file__), 'extension.cpp') SETUP = os.path.join(os.path.dirname(__file__), 'setup.py') +Py_TRACE_REFS = hasattr(sys, 'getobjects') # With MSVC on a debug build, the linker fails with: cannot open file @@ -45,6 +47,9 @@ def test_build_limited(self): self.check_build('_testcppext_limited', limited=True) def check_build(self, extension_name, std=None, limited=False): + if limited and Py_TRACE_REFS: + self.skipTest('Py_LIMITED_API is incompatible with Py_TRACE_REFS') + venv_dir = 'env' with support.setup_venv_with_pip_setuptools_wheel(venv_dir) as python_exe: self._check_build(extension_name, python_exe,