From 547b5c4cacebf67f874638b05fd1705d657e244e Mon Sep 17 00:00:00 2001 From: Chris Eibl <138194463+chris-eibl@users.noreply.github.com> Date: Sat, 22 Mar 2025 21:23:45 +0100 Subject: [PATCH 1/2] fix clangcl warning in sre.c --- Modules/_sre/sre.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Modules/_sre/sre.c b/Modules/_sre/sre.c index b0eb9d131c6469..fb4c6a96f63e1a 100644 --- a/Modules/_sre/sre.c +++ b/Modules/_sre/sre.c @@ -92,7 +92,11 @@ static unsigned int sre_toupper(unsigned int ch) { /* -------------------------------------------------------------------- */ #if defined(_MSC_VER) -#pragma optimize("agtw", on) /* doesn't seem to make much difference... */ +# if defined(__clang__) +# pragma optimize("", on) +# else +# pragma optimize("gt", on) /* doesn't seem to make much difference... */ +# endif #pragma warning(disable: 4710) /* who cares if functions are not inlined ;-) */ /* fastest possible local call under MSVC */ #define LOCAL(type) static __inline type __fastcall From 853c1ff2205873e8fcb0cdb44e9d63439492db73 Mon Sep 17 00:00:00 2001 From: Chris Eibl <138194463+chris-eibl@users.noreply.github.com> Date: Tue, 1 Apr 2025 16:34:30 +0200 Subject: [PATCH 2/2] just use "#if defined(_MSC_VER) && !defined(__clang__)" --- Modules/_sre/sre.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/Modules/_sre/sre.c b/Modules/_sre/sre.c index fb4c6a96f63e1a..602d0ab8588f62 100644 --- a/Modules/_sre/sre.c +++ b/Modules/_sre/sre.c @@ -91,12 +91,8 @@ static unsigned int sre_toupper(unsigned int ch) { /* -------------------------------------------------------------------- */ -#if defined(_MSC_VER) -# if defined(__clang__) -# pragma optimize("", on) -# else -# pragma optimize("gt", on) /* doesn't seem to make much difference... */ -# endif +#if defined(_MSC_VER) && !defined(__clang__) +#pragma optimize("agtw", on) /* doesn't seem to make much difference... */ #pragma warning(disable: 4710) /* who cares if functions are not inlined ;-) */ /* fastest possible local call under MSVC */ #define LOCAL(type) static __inline type __fastcall