From 59316f3145e7e499aa2c398088690e9db81924ac Mon Sep 17 00:00:00 2001 From: Sahil D Shah Date: Mon, 19 May 2025 11:58:54 -0400 Subject: [PATCH 1/7] Use 0 as the queue size --- Lib/socketserver.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/socketserver.py b/Lib/socketserver.py index 35b2723de3babe..aec96087ad4d6d 100644 --- a/Lib/socketserver.py +++ b/Lib/socketserver.py @@ -441,7 +441,7 @@ class TCPServer(BaseServer): socket_type = socket.SOCK_STREAM - request_queue_size = 5 + request_queue_size = 0 allow_reuse_address = False From 869d2a3a5f8e80b946335532a265ce2cdec98532 Mon Sep 17 00:00:00 2001 From: "blurb-it[bot]" <43283697+blurb-it[bot]@users.noreply.github.com> Date: Mon, 19 May 2025 17:27:22 +0000 Subject: [PATCH 2/7] =?UTF-8?q?=F0=9F=93=9C=F0=9F=A4=96=20Added=20by=20blu?= =?UTF-8?q?rb=5Fit.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst diff --git a/Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst b/Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst new file mode 100644 index 00000000000000..ca0d36a1dd12fe --- /dev/null +++ b/Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst @@ -0,0 +1 @@ +Set 0 as the default queue size for TCPServer From d99fa5a0a13ca62e881fcb84649665cd16c41ed0 Mon Sep 17 00:00:00 2001 From: Sahil D Shah Date: Mon, 19 May 2025 14:13:57 -0400 Subject: [PATCH 3/7] Default queue of 0 disables connections for some platforms --- Lib/socketserver.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/socketserver.py b/Lib/socketserver.py index aec96087ad4d6d..93b0a23be27f68 100644 --- a/Lib/socketserver.py +++ b/Lib/socketserver.py @@ -441,7 +441,7 @@ class TCPServer(BaseServer): socket_type = socket.SOCK_STREAM - request_queue_size = 0 + request_queue_size = getattr(socket, "SOMAXCONN", 5) allow_reuse_address = False From d5633d5a4c59512c5d3c4abaad77979f1b362e5a Mon Sep 17 00:00:00 2001 From: Sahil D Shah Date: Mon, 19 May 2025 14:19:48 -0400 Subject: [PATCH 4/7] Update NEWS entry and rst docs of TCPServer --- Doc/library/socketserver.rst | 4 +++- .../Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/Doc/library/socketserver.rst b/Doc/library/socketserver.rst index 59cfa136a3b7da..024495ecf2c6ec 100644 --- a/Doc/library/socketserver.rst +++ b/Doc/library/socketserver.rst @@ -23,7 +23,9 @@ There are four basic concrete server classes: invoke :meth:`~BaseServer.server_bind` and :meth:`~BaseServer.server_activate`. The other parameters are passed to the :class:`BaseServer` base class. - + + .. versionchanged:: next + Set getattr(socket, "SOMAXCONN", 5) as the default queue size for TCPServer. .. class:: UDPServer(server_address, RequestHandlerClass, bind_and_activate=True) diff --git a/Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst b/Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst index ca0d36a1dd12fe..3d598755c95ad3 100644 --- a/Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst +++ b/Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst @@ -1 +1 @@ -Set 0 as the default queue size for TCPServer +Set getattr(socket, "SOMAXCONN", 5) as the default queue size for TCPServer \ No newline at end of file From ac0af1e04e3bf688f64a3090820250f91baa7d5f Mon Sep 17 00:00:00 2001 From: Sahil D Shah Date: Mon, 19 May 2025 14:34:35 -0400 Subject: [PATCH 5/7] Fix markup errors --- Doc/library/socketserver.rst | 2 +- .../next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Doc/library/socketserver.rst b/Doc/library/socketserver.rst index 024495ecf2c6ec..3027dd803b0422 100644 --- a/Doc/library/socketserver.rst +++ b/Doc/library/socketserver.rst @@ -23,7 +23,7 @@ There are four basic concrete server classes: invoke :meth:`~BaseServer.server_bind` and :meth:`~BaseServer.server_activate`. The other parameters are passed to the :class:`BaseServer` base class. - + .. versionchanged:: next Set getattr(socket, "SOMAXCONN", 5) as the default queue size for TCPServer. diff --git a/Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst b/Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst index 3d598755c95ad3..9f5b3a88f21688 100644 --- a/Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst +++ b/Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst @@ -1 +1 @@ -Set getattr(socket, "SOMAXCONN", 5) as the default queue size for TCPServer \ No newline at end of file +Set ``getattr(socket, "SOMAXCONN", 5)`` as the default queue size for :class:`socketserver.TCPServer`. From e822cf4b8b830f2a5a2c3602ff792c262a4a7b21 Mon Sep 17 00:00:00 2001 From: Sahil D Shah Date: Mon, 19 May 2025 14:47:52 -0400 Subject: [PATCH 6/7] Update the NEWS --- .../next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst b/Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst index 9f5b3a88f21688..089268dc4c3e7b 100644 --- a/Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst +++ b/Misc/NEWS.d/next/Library/2025-05-19-17-27-21.gh-issue-80184.LOkbaw.rst @@ -1 +1 @@ -Set ``getattr(socket, "SOMAXCONN", 5)`` as the default queue size for :class:`socketserver.TCPServer`. +The default queue size is now ``socket.SOMAXCONN`` for :class:`socketserver.TCPServer`. From 5d76c7e481ba2eb9af4881b81916ca74eef9c432 Mon Sep 17 00:00:00 2001 From: Sahil D Shah Date: Mon, 19 May 2025 15:01:04 -0400 Subject: [PATCH 7/7] Update rst docs of TCPServer --- Doc/library/socketserver.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Doc/library/socketserver.rst b/Doc/library/socketserver.rst index 3027dd803b0422..753f12460b824b 100644 --- a/Doc/library/socketserver.rst +++ b/Doc/library/socketserver.rst @@ -25,7 +25,7 @@ There are four basic concrete server classes: the :class:`BaseServer` base class. .. versionchanged:: next - Set getattr(socket, "SOMAXCONN", 5) as the default queue size for TCPServer. + The default queue size is now ``socket.SOMAXCONN`` for :class:`socketserver.TCPServer`. .. class:: UDPServer(server_address, RequestHandlerClass, bind_and_activate=True)