gh-136231: Document xml.etree.ElementTree.iselement behavior when used with types #136482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to switch machines to test on Linux
Add tests verifying the new type checking behavior
Adjusts iselement() based off feedback from picnixz. Since ElementTree needs to be compatible with element-like objects, the function now checks for all attributes that are necessary to instantiate an ElementTree object and successfully write it to a file (preventing issue python#135640). This commit also incorporates other feedback requesting moving the tests and adding more tests, and adds a news entry.
Co-authored-by: Mikhail Efimov <[email protected]>
Test was written for a change to `iselement` that has since been undone
Suggested changes from @serhiy-storchaka Co-authored-by: Serhiy Storchaka <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
Split tests for _setroot into their own function and remove test for element-like objects per feedback from @serhiy-storchaka
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion in ElementTree.iselement() returns true for the Element type #136231, this documents the behavior of
iselementwhen passed a type. I'm submitting this as a draft so more input can be given.📚 Documentation preview 📚: https://cpython-previews--136482.org.readthedocs.build/