From d6ac16c7ce8c3cf4d9ef1b54e5ca4a4f980a6135 Mon Sep 17 00:00:00 2001 From: Stan Ulbrych Date: Thu, 10 Jul 2025 10:19:22 +0100 Subject: [PATCH 1/3] gh-52876 implement missing parameter --- Lib/codecs.py | 10 +++++----- .../2025-07-10-10-18-19.gh-issue-52876.9Vjrd8.rst | 3 +++ 2 files changed, 8 insertions(+), 5 deletions(-) create mode 100644 Misc/NEWS.d/next/Library/2025-07-10-10-18-19.gh-issue-52876.9Vjrd8.rst diff --git a/Lib/codecs.py b/Lib/codecs.py index fc38e922257644..9d352bc622615e 100644 --- a/Lib/codecs.py +++ b/Lib/codecs.py @@ -618,7 +618,7 @@ def readlines(self, sizehint=None, keepends=True): method and are included in the list entries. sizehint, if given, is ignored since there is no efficient - way to finding the true end-of-line. + way to find the true end-of-line. """ data = self.read() @@ -709,13 +709,13 @@ def read(self, size=-1): return self.reader.read(size) - def readline(self, size=None): + def readline(self, size=None, keepends=True): - return self.reader.readline(size) + return self.reader.readline(size, keepends) - def readlines(self, sizehint=None): + def readlines(self, sizehint=None, keepends=True): - return self.reader.readlines(sizehint) + return self.reader.readlines(sizehint, keepends) def __next__(self): diff --git a/Misc/NEWS.d/next/Library/2025-07-10-10-18-19.gh-issue-52876.9Vjrd8.rst b/Misc/NEWS.d/next/Library/2025-07-10-10-18-19.gh-issue-52876.9Vjrd8.rst new file mode 100644 index 00000000000000..ff7060464916c2 --- /dev/null +++ b/Misc/NEWS.d/next/Library/2025-07-10-10-18-19.gh-issue-52876.9Vjrd8.rst @@ -0,0 +1,3 @@ +Add missing ``keepends`` (default ``True``) parameter to +:meth:`codecs.StreamReaderWriter.readline` and +:meth:`codecs.StreamReaderWriter.readlines`. From f65d0b56685154d57999e45af1714c64d5c1bf67 Mon Sep 17 00:00:00 2001 From: Stan Ulbrych Date: Thu, 10 Jul 2025 10:23:13 +0100 Subject: [PATCH 2/3] Fix docstring typo --- Lib/codecs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Lib/codecs.py b/Lib/codecs.py index 9d352bc622615e..e4a8010aba90a5 100644 --- a/Lib/codecs.py +++ b/Lib/codecs.py @@ -618,7 +618,7 @@ def readlines(self, sizehint=None, keepends=True): method and are included in the list entries. sizehint, if given, is ignored since there is no efficient - way to find the true end-of-line. + way of finding the true end-of-line. """ data = self.read() From 31e52eb096a583495b904ce24cc0591e70599868 Mon Sep 17 00:00:00 2001 From: Stan Ulbrych Date: Thu, 10 Jul 2025 10:57:58 +0100 Subject: [PATCH 3/3] Unlink NEWS refs --- .../Library/2025-07-10-10-18-19.gh-issue-52876.9Vjrd8.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Misc/NEWS.d/next/Library/2025-07-10-10-18-19.gh-issue-52876.9Vjrd8.rst b/Misc/NEWS.d/next/Library/2025-07-10-10-18-19.gh-issue-52876.9Vjrd8.rst index ff7060464916c2..a835306868d3dc 100644 --- a/Misc/NEWS.d/next/Library/2025-07-10-10-18-19.gh-issue-52876.9Vjrd8.rst +++ b/Misc/NEWS.d/next/Library/2025-07-10-10-18-19.gh-issue-52876.9Vjrd8.rst @@ -1,3 +1,3 @@ Add missing ``keepends`` (default ``True``) parameter to -:meth:`codecs.StreamReaderWriter.readline` and -:meth:`codecs.StreamReaderWriter.readlines`. +:meth:`!codecs.StreamReaderWriter.readline` and +:meth:`!codecs.StreamReaderWriter.readlines`.