-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
bpo-22367: Add open_file_descriptor parameter to fcntl.lockf() #17099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition I would add a test based on the example https://www.gnu.org/software/libc/manual/html_node/Open-File-Description-Locks-Example.html
Thanks for the review. |
df8640a
to
e69a9f6
Compare
@serhiy-storchaka @vstinner |
96d57b8
to
d6e2fc1
Compare
I left a question on https://bugs.python.org/issue22367 which related to the parameter name. |
@pitrou @serhiy-storchaka @vstinner Thanks for the review. @vstinner please take a look at my suggestion on https://bugs.python.org/msg356329 which suggests changing the parameter name from |
@vstinner If you don't mind can you leave some feedback on this PR? |
@vstinner Let's reopen this PR when we need this feature again ;) |
https://bugs.python.org/issue22367