Skip to content

bpo-22367: Add open_file_descriptor parameter to fcntl.lockf() #17099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Nov 9, 2019

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corona10
Copy link
Member Author

corona10 commented Nov 9, 2019

@serhiy-storchaka

In addition I would add a test based on the example https://www.gnu.org/software/libc/manual/html_node/Open-File-Description-Locks-Example.html

Thanks for the review.
I will add unit test based on the link.

@corona10 corona10 force-pushed the bpo-22367 branch 2 times, most recently from df8640a to e69a9f6 Compare November 10, 2019 13:30
@corona10
Copy link
Member Author

@corona10 corona10 force-pushed the bpo-22367 branch 2 times, most recently from 96d57b8 to d6e2fc1 Compare November 10, 2019 15:12
@corona10
Copy link
Member Author

I left a question on https://bugs.python.org/issue22367 which related to the parameter name.

@corona10
Copy link
Member Author

@pitrou @serhiy-storchaka @vstinner

Thanks for the review.
I 've updated the PR.

@vstinner please take a look at my suggestion on https://bugs.python.org/msg356329 which suggests changing the parameter name from open_file_descriptor to open_file_description.

@corona10
Copy link
Member Author

@vstinner If you don't mind can you leave some feedback on this PR?

@corona10
Copy link
Member Author

@vstinner Let's reopen this PR when we need this feature again ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants