Skip to content

Commit 76416e9

Browse files
authored
Revert "Upgrade cmake version to 3.22.1 to build triton (#1331)" (#1351)
* Revert "Upgrade cmake version to 3.22.1 to build triton (#1331)" This reverts commit 18c5017. * Selective revert * Get cmake from pip * Use 3.18.2 from conda
1 parent a754b40 commit 76416e9

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

common/install_conda.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ chmod +x Miniconda3-latest-Linux-x86_64.sh
99
bash ./Miniconda3-latest-Linux-x86_64.sh -b -p /opt/conda
1010
rm Miniconda3-latest-Linux-x86_64.sh
1111
export PATH=/opt/conda/bin:$PATH
12-
# cmake-3.22.1 from conda, same as the one used by PyTorch CI. The system cmake
13-
# is too old to build triton
14-
conda install -y conda-build anaconda-client git ninja cmake=3.22.1
12+
# The cmake version here needs to match with the minimum version of cmake
13+
# supported by PyTorch (3.18). There is only 3.18.2 on anaconda
14+
conda install -y conda-build anaconda-client git ninja cmake=3.18.2
1515
conda remove -y --force patchelf

manywheel/Dockerfile

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,9 @@ RUN wget http://dl.fedoraproject.org/pub/epel/epel-release-latest-7.noarch.rpm &
2121
rpm -ivh epel-release-latest-7.noarch.rpm && \
2222
rm -f epel-release-latest-7.noarch.rpm
2323

24-
# cmake-3.22.1 from pip, same as the one used by PyTorch CI. cmake-3.18.4 is
25-
# too old to build triton now
24+
# cmake-3.18.4 from pip
2625
RUN yum install -y python3-pip && \
27-
python3 -mpip install cmake==3.22.1 && \
26+
python3 -mpip install cmake==3.18.4 && \
2827
ln -s /usr/local/bin/cmake /usr/bin/cmake
2928

3029
RUN yum install -y autoconf aclocal automake make

0 commit comments

Comments
 (0)