Skip to content

Fix erroneous logic that was skipping msccl files even for ROCm5.6 #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 21, 2023
Merged

Fix erroneous logic that was skipping msccl files even for ROCm5.6 #1546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions manywheel/build_rocm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,10 +204,17 @@ if [[ $ROCM_INT -ge 50500 ]]; then

DEPS_AUX_SRCLIST+=(${MIOPEN_SHARE_FILES[@]/#/$MIOPEN_SHARE_SRC/})
DEPS_AUX_DSTLIST+=(${MIOPEN_SHARE_FILES[@]/#/$MIOPEN_SHARE_DST/})
elif [[ $ROCM_INT -ge 50600 ]]; then
fi

if [[ $ROCM_INT -ge 50600 ]]; then
# RCCL library files
RCCL_SHARE_SRC=$ROCM_HOME/lib/msccl-algorithms
RCCL_SHARE_DST=lib/msccl-algorithms
if [[ $ROCM_INT -ge 50700 ]]; then
RCCL_SHARE_SRC=$ROCM_HOME/share/rccl/msccl-algorithms
RCCL_SHARE_DST=share/rccl/msccl-algorithms
else
RCCL_SHARE_SRC=$ROCM_HOME/lib/msccl-algorithms
RCCL_SHARE_DST=lib/msccl-algorithms
fi
RCCL_SHARE_FILES=($(ls $RCCL_SHARE_SRC))

DEPS_AUX_SRCLIST+=(${RCCL_SHARE_FILES[@]/#/$RCCL_SHARE_SRC/})
Expand Down