From af3f2b7d9b25380e3edf68fdf4c0f93af8b81805 Mon Sep 17 00:00:00 2001 From: Xu Han Date: Wed, 24 Apr 2024 23:06:23 +0800 Subject: [PATCH] Revert "Windows use mkl static lib. (#1790)" This reverts commit 9f33088bac1f6e474fbaadbaae1362f543794ffc. --- windows/build_pytorch.bat | 2 +- windows/condaenv.bat | 10 +++++----- windows/internal/copy.bat | 5 ++++- windows/internal/copy_cpu.bat | 7 ++++++- 4 files changed, 16 insertions(+), 8 deletions(-) diff --git a/windows/build_pytorch.bat b/windows/build_pytorch.bat index 6853234c9..750d3c5e3 100644 --- a/windows/build_pytorch.bat +++ b/windows/build_pytorch.bat @@ -122,7 +122,7 @@ for %%v in (%DESIRED_PYTHON_PREFIX%) do ( ) else ( set "PATH=%CONDA_HOME%\envs\%%v;%CONDA_HOME%\envs\%%v\scripts;%CONDA_HOME%\envs\%%v\Library\bin;%ORIG_PATH%" ) - pip install ninja + pip install ninja mkl-include==2021.4.0 mkl-devel==2021.4.0 @setlocal :: Set Flags if not "%CUDA_VERSION%"=="cpu" ( diff --git a/windows/condaenv.bat b/windows/condaenv.bat index 74a8c9449..022e61891 100644 --- a/windows/condaenv.bat +++ b/windows/condaenv.bat @@ -9,11 +9,11 @@ FOR %%v IN (%DESIRED_PYTHON%) DO ( set PYTHON_VERSION_STR=%%v set PYTHON_VERSION_STR=!PYTHON_VERSION_STR:.=! conda remove -n py!PYTHON_VERSION_STR! --all -y || rmdir %CONDA_HOME%\envs\py!PYTHON_VERSION_STR! /s - if "%%v" == "3.8" call conda create -n py!PYTHON_VERSION_STR! -y -q numpy=1.11 "intel::mkl-static=2020.2" "intel::mkl-include=2020.2" pyyaml boto3 cmake ninja typing_extensions python=%%v - if "%%v" == "3.9" call conda create -n py!PYTHON_VERSION_STR! -y -q numpy>=1.11 "intel::mkl-static=2020.2" "intel::mkl-include=2020.2" pyyaml boto3 cmake ninja typing_extensions python=%%v - if "%%v" == "3.10" call conda create -n py!PYTHON_VERSION_STR! -y -q -c=conda-forge numpy=1.21.3 "intel::mkl-static=2020.2" "intel::mkl-include=2020.2" intel-openmp=2023.2.0 pyyaml boto3 "cmake=3.19.6" ninja typing_extensions python=%%v - if "%%v" == "3.11" call conda create -n py!PYTHON_VERSION_STR! -y -q -c=conda-forge numpy=1.23.4 "intel::mkl-static=2020.2" "intel::mkl-include=2020.2" intel-openmp=2023.2.0 pyyaml boto3 "cmake=3.19.6" ninja typing_extensions python=%%v - if "%%v" == "3.12" call conda create -n py!PYTHON_VERSION_STR! -y -q -c=conda-forge numpy=1.26.0 "intel::mkl-static=2023.1" "intel::mkl-include=2023.1" intel-openmp=2023.2.0 pyyaml boto3 "cmake=3.19.6" ninja typing_extensions python=%%v + if "%%v" == "3.8" call conda create -n py!PYTHON_VERSION_STR! -y -q numpy=1.11 "mkl=2020.2" pyyaml boto3 cmake ninja typing_extensions python=%%v + if "%%v" == "3.9" call conda create -n py!PYTHON_VERSION_STR! -y -q numpy>=1.11 "mkl=2020.2" pyyaml boto3 cmake ninja typing_extensions python=%%v + if "%%v" == "3.10" call conda create -n py!PYTHON_VERSION_STR! -y -q -c=conda-forge numpy=1.21.3 "mkl=2020.2" intel-openmp=2023.2.0 pyyaml boto3 "cmake=3.19.6" ninja typing_extensions python=%%v + if "%%v" == "3.11" call conda create -n py!PYTHON_VERSION_STR! -y -q -c=conda-forge numpy=1.23.4 "mkl=2020.2" intel-openmp=2023.2.0 pyyaml boto3 "cmake=3.19.6" ninja typing_extensions python=%%v + if "%%v" == "3.12" call conda create -n py!PYTHON_VERSION_STR! -y -q -c=conda-forge numpy=1.26.0 "mkl=2023.1" intel-openmp=2023.2.0 pyyaml boto3 "cmake=3.19.6" ninja typing_extensions python=%%v ) endlocal diff --git a/windows/internal/copy.bat b/windows/internal/copy.bat index b2d078944..9893fc7c5 100755 --- a/windows/internal/copy.bat +++ b/windows/internal/copy.bat @@ -11,7 +11,10 @@ copy "%CUDA_PATH%\extras\CUPTI\lib64\cupti64_*.dll*" pytorch\torch\lib copy "C:\Program Files\NVIDIA Corporation\NvToolsExt\bin\x64\nvToolsExt64_1.dll*" pytorch\torch\lib copy "%CONDA_LIB_PATH%\libiomp*5md.dll" pytorch\torch\lib - +IF "%PACKAGE_TYPE%"=="libtorch" ( + copy "%CONDA_LIB_PATH%\mkl_intel_thread.1.dll" pytorch\torch\lib + copy "%CONDA_LIB_PATH%\mkl_core.1.dll" pytorch\torch\lib +) :: Should be set in build_pytorch.bat copy "%libuv_ROOT%\bin\uv.dll" pytorch\torch\lib diff --git a/windows/internal/copy_cpu.bat b/windows/internal/copy_cpu.bat index 864180d85..0a4c0dabb 100755 --- a/windows/internal/copy_cpu.bat +++ b/windows/internal/copy_cpu.bat @@ -1,3 +1,8 @@ copy "%CONDA_LIB_PATH%\libiomp*5md.dll" pytorch\torch\lib :: Should be set in build_pytorch.bat -copy "%libuv_ROOT%\bin\uv.dll" pytorch\torch\lib \ No newline at end of file +copy "%libuv_ROOT%\bin\uv.dll" pytorch\torch\lib + +IF "%PACKAGE_TYPE%"=="libtorch" ( + copy "%CONDA_LIB_PATH%\mkl_intel_thread.1.dll" pytorch\torch\lib + copy "%CONDA_LIB_PATH%\mkl_core.1.dll" pytorch\torch\lib +)