Add mixed integer precision test for op_mul #11206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
manuelcandales
approved these changes
May 29, 2025
because 100 * 100 mod 256 = 16 this is how ATen works, because of functionalization |
JacobSzwejbka
added a commit
that referenced
this pull request
Jun 10, 2025
This reverts commit 3a4ec6e.
swolchok
added a commit
that referenced
this pull request
Jun 24, 2025
…portedTensorDtypes::BOOL (#9584)", new op_mul test (#11206) These were reverted because they were part of a stack with interenal test failures. Original #9585 summary: We were requiring ourselves to compute at double-precision, but ATen actually converts non-floating-point types to `float` by default, not `double`. Use the ATen tolerances everywhere. Original #9584 summary: none Original #11206 summary: This tests a possibly-surprising result: int8(100) * int8(100) with output type of long is 16 in ATen, even though the output type can hold 10000. Differential Revision: [D76754823](https://our.internmc.facebook.com/intern/diff/D76754823/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jun 24, 2025
…portedTensorDtypes::BOOL (#9584)", new op_mul test (#11206) These were reverted because they were part of a stack with interenal test failures. Original #9585 summary: We were requiring ourselves to compute at double-precision, but ATen actually converts non-floating-point types to `float` by default, not `double`. Use the ATen tolerances everywhere. Original #9584 summary: none Original #11206 summary: This tests a possibly-surprising result: int8(100) * int8(100) with output type of long is 16 in ATen, even though the output type can hold 10000. Differential Revision: [D76754823](https://our.internmc.facebook.com/intern/diff/D76754823/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jun 24, 2025
…portedTensorDtypes::BOOL (#9584)", new op_mul test (#11206) These were reverted because they were part of a stack with interenal test failures. Original #9585 summary: We were requiring ourselves to compute at double-precision, but ATen actually converts non-floating-point types to `float` by default, not `double`. Use the ATen tolerances everywhere. Original #9584 summary: none Original #11206 summary: This tests a possibly-surprising result: int8(100) * int8(100) with output type of long is 16 in ATen, even though the output type can hold 10000. Differential Revision: [D76754823](https://our.internmc.facebook.com/intern/diff/D76754823/) [ghstack-poisoned]
swolchok
added a commit
that referenced
this pull request
Jun 24, 2025
…portedTensorDtypes::BOOL (#9584)", new op_mul test (#11206) These were reverted because they were part of a stack with interenal test failures. Original #9585 summary: We were requiring ourselves to compute at double-precision, but ATen actually converts non-floating-point types to `float` by default, not `double`. Use the ATen tolerances everywhere. Original #9584 summary: none Original #11206 summary: This tests a possibly-surprising result: int8(100) * int8(100) with output type of long is 16 in ATen, even though the output type can hold 10000. Differential Revision: [D76754823](https://our.internmc.facebook.com/intern/diff/D76754823/) [ghstack-poisoned]
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
This tests a possibly-surprising result: int8(100) * int8(100) with output type of long is 16 in ATen, even though the output type can hold 10000. ghstack-source-id: c946ff3 ghstack-comment-id: 2917867829 Pull-Request-resolved: pytorch/executorch#11206
swolchok
added a commit
that referenced
this pull request
Jun 26, 2025
…portedTensorDtypes::BOOL (#9584)", new op_mul test (#11206) (#11976) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: #11942 by @swolchok ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/473/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/473/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/473/orig @diff-train-skip-merge Co-authored-by: Scott Wolchok <[email protected]>
hinriksnaer
pushed a commit
to hinriksnaer/executorch
that referenced
this pull request
Jun 26, 2025
…Add SupportedTensorDtypes::BOOL (pytorch#9584)", new op_mul test (pytorch#11206) (pytorch#11976) This PR was created by the merge bot to help merge the original PR into the main branch. ghstack PR number: pytorch#11942 by @swolchok ^ Please use this as the source of truth for the PR details, comments, and reviews ghstack PR base: https://github.com/pytorch/executorch/tree/gh/swolchok/473/base ghstack PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/473/head Merge bot PR base: https://github.com/pytorch/executorch/tree/main Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/swolchok/473/orig @diff-train-skip-merge Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests a possibly-surprising result: int8(100) * int8(100) with output type of long is 16 in ATen, even though the output type can hold 10000.