Skip to content

Reapply: "relax tolerances for all unary float ops (#9585)", "Add SupportedTensorDtypes::BOOL (#9584)", new op_mul test (#11206) #11942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2025

Conversation

swolchok
Copy link
Contributor

@swolchok swolchok commented Jun 24, 2025

Stack from ghstack (oldest at bottom):

These were reverted because they were part of a stack with interenal test failures.

Original #9585 summary:
We were requiring ourselves to compute at double-precision, but ATen
actually converts non-floating-point types to float by default, not
double. Use the ATen tolerances everywhere.

Original #9584 summary: none

Original #11206 summary:
This tests a possibly-surprising result: int8(100) * int8(100) with
output type of long is 16 in ATen, even though the output type can hold 10000.

Differential Revision: D76754823

…portedTensorDtypes::BOOL (#9584)", new op_mul test (#11206)

These were reverted because they were part of a stack with interenal test failures.

Original #9585 summary:
We were requiring ourselves to compute at double-precision, but ATen
actually converts non-floating-point types to `float` by default, not
`double`. Use the ATen tolerances everywhere.

Original #9584 summary: none

Original #11206 summary:
This tests a possibly-surprising result: int8(100) * int8(100) with
output type of long is 16 in ATen, even though the output type can hold 10000.

Differential Revision: [D76754823](https://our.internmc.facebook.com/intern/diff/D76754823/)

[ghstack-poisoned]
@swolchok swolchok requested a review from manuelcandales as a code owner June 24, 2025 22:44
Copy link

pytorch-bot bot commented Jun 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11942

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5c819bd with merge base 91c9ffa (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 24, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D76754823

kedarnath03 pushed a commit to kedarnath03/executorch that referenced this pull request Jun 25, 2025
…portedTensorDtypes::BOOL (#9584)", new op_mul test (#11206)

These were reverted because they were part of a stack with interenal test failures.

Original #9585 summary:
We were requiring ourselves to compute at double-precision, but ATen
actually converts non-floating-point types to `float` by default, not
`double`. Use the ATen tolerances everywhere.

Original #9584 summary: none

Original #11206 summary:
This tests a possibly-surprising result: int8(100) * int8(100) with
output type of long is 16 in ATen, even though the output type can hold 10000.

Differential Revision: [D76754823](https://our.internmc.facebook.com/intern/diff/D76754823/)

ghstack-source-id: 292469055
Pull Request resolved: pytorch/executorch#11942
@swolchok swolchok added the release notes: none Do not include this in the release notes label Jun 25, 2025
@facebook-github-bot facebook-github-bot merged commit 5c676dc into gh/swolchok/473/base Jun 25, 2025
98 of 101 checks passed
@facebook-github-bot facebook-github-bot deleted the gh/swolchok/473/head branch June 25, 2025 18:32
swolchok added a commit that referenced this pull request Jun 26, 2025
…portedTensorDtypes::BOOL (#9584)", new op_mul test (#11206) (#11976)

This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #11942 by
@swolchok
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/swolchok/473/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/473/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/473/orig
@diff-train-skip-merge

Co-authored-by: Scott Wolchok <[email protected]>
hinriksnaer pushed a commit to hinriksnaer/executorch that referenced this pull request Jun 26, 2025
…Add SupportedTensorDtypes::BOOL (pytorch#9584)", new op_mul test (pytorch#11206) (pytorch#11976)

This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: pytorch#11942 by
@swolchok
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/swolchok/473/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/473/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/swolchok/473/orig
@diff-train-skip-merge

Co-authored-by: Scott Wolchok <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported release notes: none Do not include this in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants