From 9c125ff7e9524ff5770af02b8eb832e09083094c Mon Sep 17 00:00:00 2001 From: Huy Do Date: Mon, 24 Jul 2023 15:14:45 -0700 Subject: [PATCH 1/4] Try out buck2 --- .github/workflows/pull.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/.github/workflows/pull.yml b/.github/workflows/pull.yml index e54cff092f1..9893e39da90 100644 --- a/.github/workflows/pull.yml +++ b/.github/workflows/pull.yml @@ -28,6 +28,10 @@ jobs: ln -s "${WORKSPACE}" executorch # Install executorch source executorch/install.sh + popd # Just print out the list of packages for debugging pip list + + buck2 build //test:size_test_all_ops + sleep 300 From ae4eddaefe8b9fdc1a1288e81e75e11298c0a315 Mon Sep 17 00:00:00 2001 From: Huy Do Date: Mon, 24 Jul 2023 15:17:26 -0700 Subject: [PATCH 2/4] Debug --- .github/workflows/pull.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull.yml b/.github/workflows/pull.yml index 9893e39da90..df8df4df6a0 100644 --- a/.github/workflows/pull.yml +++ b/.github/workflows/pull.yml @@ -33,5 +33,5 @@ jobs: # Just print out the list of packages for debugging pip list - buck2 build //test:size_test_all_ops sleep 300 + buck2 build //test:size_test_all_ops From a1551a3ef703f37ee99fe32c7907eca3e274f05d Mon Sep 17 00:00:00 2001 From: Huy Do Date: Mon, 24 Jul 2023 16:50:00 -0700 Subject: [PATCH 3/4] Install lld --- .ci/docker/common/install_clang.sh | 2 ++ .github/workflows/pull.yml | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.ci/docker/common/install_clang.sh b/.ci/docker/common/install_clang.sh index 3713ca71c8e..1138db27262 100755 --- a/.ci/docker/common/install_clang.sh +++ b/.ci/docker/common/install_clang.sh @@ -7,6 +7,8 @@ install_ubuntu() { apt-get install -y --no-install-recommends clang-"$CLANG_VERSION" apt-get install -y --no-install-recommends llvm-"$CLANG_VERSION" + # Also require LLD linker from llvm + apt-get install -y lld # Use update-alternatives to make this version the default update-alternatives --install /usr/bin/clang clang /usr/bin/clang-"$CLANG_VERSION" 50 diff --git a/.github/workflows/pull.yml b/.github/workflows/pull.yml index df8df4df6a0..22b7072c037 100644 --- a/.github/workflows/pull.yml +++ b/.github/workflows/pull.yml @@ -14,11 +14,12 @@ concurrency: jobs: buck-build-test: name: buck-build-test - uses: pytorch/test-infra/.github/workflows/linux_job.yml@main + uses: pytorch/test-infra/.github/workflows/linux_job.yml@init-submodules with: runner: linux.2xlarge docker-image: executorch-ubuntu-22.04-clang12 fetch-depth: 0 + submodules: 'true' ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }} script: | WORKSPACE=$(pwd) @@ -33,5 +34,4 @@ jobs: # Just print out the list of packages for debugging pip list - sleep 300 buck2 build //test:size_test_all_ops From b6b9f13d0a16cf5909b5d45f2b8629c8981b3e5e Mon Sep 17 00:00:00 2001 From: Huy Do Date: Mon, 24 Jul 2023 16:58:49 -0700 Subject: [PATCH 4/4] Clean up --- .github/workflows/pull.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/pull.yml b/.github/workflows/pull.yml index 22b7072c037..e150ebbbb20 100644 --- a/.github/workflows/pull.yml +++ b/.github/workflows/pull.yml @@ -14,7 +14,7 @@ concurrency: jobs: buck-build-test: name: buck-build-test - uses: pytorch/test-infra/.github/workflows/linux_job.yml@init-submodules + uses: pytorch/test-infra/.github/workflows/linux_job.yml@main with: runner: linux.2xlarge docker-image: executorch-ubuntu-22.04-clang12 @@ -33,5 +33,3 @@ jobs: # Just print out the list of packages for debugging pip list - - buck2 build //test:size_test_all_ops