Skip to content

fix permute copy name #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

mcr229
Copy link
Contributor

@mcr229 mcr229 commented Aug 19, 2023

Summary:
We have a node_visitor for permute already, it was mistakenly named static_transpose after its xnnpack counterpart. permute_copy should not be skipped. It should only be skipped when applied to linear weights.

Instead our linear conversion pass will convert away any permute_copies which are not actually to be executed.

Differential Revision: D48488930

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 19, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48488930

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48488930

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48488930

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48488930

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48488930

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48488930

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48488930

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48488930

mcr229 and others added 2 commits August 23, 2023 15:12
Summary:
Pull Request resolved: pytorch/executorch#66

DQ Linear runtime logic for XNNPACK is FB internal only, so we are adding a flag in the dq linear logic to remove dq linear logic from xnnpack delegate in OSS

Differential Revision: D48335277

fbshipit-source-id: 6e9039c2df2ff68960a7a011a3dcc341c5b41403
Summary:
Pull Request resolved: pytorch/executorch#80

We have a node_visitor for permute already, it was mistakenly named static_transpose after its xnnpack counterpart. permute_copy should not be skipped. It should only be skipped when applied to linear weights.

Instead our linear conversion pass will convert away any permute_copies which are not actually to be executed.

Reviewed By: kirklandsign

Differential Revision: D48488930

fbshipit-source-id: 9d84e00bdfa04828768e8d0e352817a0348b0cc6
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D48488930

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in def08cf.

larryliu0820 pushed a commit that referenced this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants