-
Notifications
You must be signed in to change notification settings - Fork 628
fix permute copy name #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request was exported from Phabricator. Differential Revision: D48488930 |
This pull request was exported from Phabricator. Differential Revision: D48488930 |
c95b2a6
to
c746397
Compare
This pull request was exported from Phabricator. Differential Revision: D48488930 |
c746397
to
b9d88f5
Compare
This pull request was exported from Phabricator. Differential Revision: D48488930 |
b9d88f5
to
b400273
Compare
This pull request was exported from Phabricator. Differential Revision: D48488930 |
b400273
to
7387f89
Compare
This pull request was exported from Phabricator. Differential Revision: D48488930 |
7387f89
to
e76d877
Compare
This pull request was exported from Phabricator. Differential Revision: D48488930 |
e76d877
to
ccb1686
Compare
This pull request was exported from Phabricator. Differential Revision: D48488930 |
ccb1686
to
7f88285
Compare
Summary: Pull Request resolved: pytorch/executorch#66 DQ Linear runtime logic for XNNPACK is FB internal only, so we are adding a flag in the dq linear logic to remove dq linear logic from xnnpack delegate in OSS Differential Revision: D48335277 fbshipit-source-id: 6e9039c2df2ff68960a7a011a3dcc341c5b41403
Summary: Pull Request resolved: pytorch/executorch#80 We have a node_visitor for permute already, it was mistakenly named static_transpose after its xnnpack counterpart. permute_copy should not be skipped. It should only be skipped when applied to linear weights. Instead our linear conversion pass will convert away any permute_copies which are not actually to be executed. Reviewed By: kirklandsign Differential Revision: D48488930 fbshipit-source-id: 9d84e00bdfa04828768e8d0e352817a0348b0cc6
This pull request was exported from Phabricator. Differential Revision: D48488930 |
7f88285
to
cbd9c22
Compare
This pull request has been merged in def08cf. |
Summary:
We have a node_visitor for permute already, it was mistakenly named static_transpose after its xnnpack counterpart. permute_copy should not be skipped. It should only be skipped when applied to linear weights.
Instead our linear conversion pass will convert away any permute_copies which are not actually to be executed.
Differential Revision: D48488930