Skip to content

Enable model based selective build on xplat #9205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Enable model based selective build on xplat #9205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions codegen/tools/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ def define_common_targets(is_fbcode = False):
deps = [
":gen_oplist_lib",
],
preload_deps = [] if runtime.is_oss else ["//executorch/codegen/tools/fb:selective_build"], # TODO(larryliu0820) :selective_build doesn't build in OSS yet
package_style = "inplace",
visibility = [
"//executorch/...",
Expand Down
2 changes: 1 addition & 1 deletion shim_et/xplat/executorch/build/runtime_wrapper.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ def _patch_kwargs_common(kwargs):
# Patch up references to "//executorch/..." in lists of build targets,
# if necessary.
use_static_deps = kwargs.pop("use_static_deps", False)
for dep_type in ("deps", "exported_deps", "visibility"):
for dep_type in ("deps", "exported_deps", "visibility", "preload_deps"):
if kwargs.get(dep_type):
# deps may contain select() elements, dicts that map names to lists
# of targets. selects.apply() will run the provided function on all
Expand Down
Loading