[BugFix] Minor fixes to wandb logger

[itwasabhi]

Description

Simplifications to wandb logger.

Motivation and Context

See

• I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Remove all that do not apply:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds core functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (update in the documentation)
• Example (update in the folder of examples)

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

• I have read the CONTRIBUTION guide (required)
• My change requires a change to the documentation.
• I have updated the tests accordingly (required for a bug fix or a new feature).
• I have updated the documentation accordingly.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/2999

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

• linux.aws.h100.8 instance is down, potentially longer queue on linux.aws.h100

❌ 3 New Failures, 1 Pending, 5 Unrelated Failures

As of commit 42090d2 with merge base 851a041 ():

NEW FAILURES - The following jobs have failed:

• Continuous Benchmark (PR) / GPU Pytest benchmark (gh)
  RuntimeError: PassManager::run failed
• Continuous Benchmark / GPU Pytest benchmark (gh)
  RuntimeError: PassManager::run failed
• Habitat Tests on Linux / tests (3.9, 12.8) / linux-job (gh)
  RuntimeError: Command docker exec -t 069ca17977cc38f8599477b90ace628b4b1f4f3bb1ecbc04a6c8385f0f01fe98 /exec failed with exit code 1

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• Libs Tests on Linux / unittests-gym (3.9, 12.8) / linux-job (gh) (trunk failure)
  AttributeError: module 'torch.utils._pytree' has no attribute 'register_pytree_node'
• LLM Tests on Linux / unittests (3.9, 12.8) / linux-job (gh) (trunk failure)
  ##[error]The operation was canceled.
• Unit-tests on Linux / tests-gpu (3.11, 12.8) / linux-job (gh) (trunk failure)
  test/test_distributed.py::TestRayCollector::test_ray_collector_policy_constructor
• Unit-tests on Linux / tests-olddeps (3.9, 11.6) / linux-job (gh) (trunk failure)
  AttributeError: module 'torch.utils._pytree' has no attribute 'register_pytree_node'
• Unit-tests on Linux / tests-stable-gpu (3.10, 11.8) / linux-job (gh) (trunk failure)
  test/test_distributed.py::TestRayCollector::test_ray_collector_policy_constructor

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[itwasabhi]

Seems like this was mistakenly copied from tensorbaord logger. I dont see why its needed here.

[vmoens]

Should I review this or is it still a draft?

[itwasabhi]

I havent ran tests, but please do review!

The changes should be good as is and work locally; i'm assuming I might be missing some context as to why this wasnt this simple in the first place :)

[vmoens]

I would suggest to run the wandb tests in test_loggers.py

python test/test_loggers.py -k wandb

Currently they are failing on this branch

[itwasabhi]

@vmoens Synced with head and addressed failing tests.

Note that users would see a change in their wandb boards with this pr (as the step count is propagated differently), but this is a better use of the wandb api

[vmoens]

Sure I would personally not consider that as BC breaking :)

[vmoens]

LGTM thanks for this!