Skip to content

add nvidia driver for cuda arm wheel #5218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add nvidia driver for cuda arm wheel #5218

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
167a461
add nvidia driver for cuda arm wheel
tinglvv May 19, 2024
55b882f
update var name
tinglvv May 19, 2024
63aa40b
Add var ARCH_TYPE and default to x86_64
tinglvv May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion .github/actions/setup-nvidia/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,16 @@ inputs:
required: false
type: string
default: "550.54.15" # https://docs.nvidia.com/datacenter/tesla/tesla-release-notes-550-54-15/index.html
GPU_ARCH_TYPE:
description: GPU Arch type #"cuda", "cuda-aarch64"
required: false
type: string
ARCH_TYPE:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is ARCH_TYPE used?
I think it is safe to assume setup-nvidia is only called for GPU instances, where if it is not cuda, it must be cuda-aarch64.
GPU_ARCH_TYPE is enough?

description: CPU Arch Type
required: false
type: string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we set a default "x86" and only add if statement for sbsa

default: "x86_64"


runs:
using: composite
Expand All @@ -16,6 +26,10 @@ runs:
uses: nick-fields/retry@3e91a01664abd3c5cd539100d10d33b9c5b68482
env:
DRIVER_VERSION: ${{ inputs.driver-version }}
GPU_ARCH_TYPE: ${{ inputs.GPU_ARCH_TYPE }}
ARCH_TYPE: ${{ inputs.ARCH_TYPE }}
${{ if eq(inputs.GPU_ARCH_TYPE , 'cuda-aarch64') }}:
ARCH_TYPE: sbsa
with:
timeout_minutes: 10
max_attempts: 3
Expand All @@ -25,7 +39,7 @@ runs:
set -eou pipefail

DISTRIBUTION=$(. /etc/os-release;echo $ID$VERSION_ID)
DRIVER_FN="NVIDIA-Linux-x86_64-${DRIVER_VERSION}.run"
DRIVER_FN="NVIDIA-Linux-${ARCH_TYPE}-${DRIVER_VERSION}.run"
YUM_REPO_URL="https://nvidia.github.io/nvidia-docker/${DISTRIBUTION}/nvidia-docker.repo"

install_nvidia_docker2_amzn2() {
Expand Down