From 2abeec29c51b066b84671d9a2839b83ac68a244c Mon Sep 17 00:00:00 2001 From: "Mr. Walls" Date: Tue, 20 Aug 2024 15:41:11 -0700 Subject: [PATCH 1/2] House Keeping for PR #34 Includes: - Fixes for https://github.com/reactive-firewall/python-repo/pull/34/files#r1722492778 - Fixes for https://github.com/reactive-firewall/python-repo/pull/34/files#r1722494177 - Fixes for https://github.com/reactive-firewall/python-repo/pull/34/files#r1722506148 --- .github/CONTRIBUTING.md | 6 ++---- .github/ISSUE_TEMPLATE.md | 2 +- .github/ISSUE_TEMPLATE/bug_report.md | 6 +++--- .github/ISSUE_TEMPLATE/house-keeping.md | 23 +++++++++++++++++++++++ .github/labeler.yml | 2 ++ docs/conf.py | 2 +- setup.cfg | 7 +++++-- setup.py | 2 +- 8 files changed, 38 insertions(+), 12 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE/house-keeping.md diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index a93d9cb..f8bfd8a 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -31,7 +31,7 @@ Here is a brief explanation on how I triage incoming tickets to get a better sen When sitting down to do some triaging work, start with the list of untriaged tickets. Consider all tickets that do not have a label as untriaged. The first step is to categorize the ticket into one of the following categories and either close the ticket or assign an appropriate lable. The reported issue * is not valid -If you think the ticket is invalid comment why you think it is invalid, then close the ticket. Tickets might be invalid if they were already fixed in the past or it was decided that the proposed feature will not be implemented because it does not conform with the overall goal of Pocket-PiAI Project. Also if you happen to know that the problem was already reported, label the ticket with Status: duplicate, reference the other ticket that is already addressing the problem and close the duplicate. +If you think the ticket is invalid comment why you think it is invalid, then close the ticket. Tickets might be invalid if they were already fixed in the past or it was decided that the proposed feature will not be implemented because it does not conform with the overall goal of Python-Repo Project. Also if you happen to know that the problem was already reported, label the ticket with Status: duplicate, reference the other ticket that is already addressing the problem and close the duplicate. Examples: @@ -107,9 +107,7 @@ This is the checklist that I try to go through for every single pull request tha - [ ] Do the tests pass for all of the following? If not, write a note in the PR, or fix them yourself. - - [ ] Python 3.8 - Mac - - [ ] Python 3.8 - Linux (OPTIONAL) - - [ ] Python 3.9 - Linux + - [ ] Python 3.9 - Linux (OPTIONAL) - [ ] Python 3.9 (or Newer) - Mac - [ ] Python 3.10 - Linux - [ ] Python 3.11 - Linux diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md index 751474c..0a88d6d 100644 --- a/.github/ISSUE_TEMPLATE.md +++ b/.github/ISSUE_TEMPLATE.md @@ -9,7 +9,7 @@ >> `uname -a` - [ ] linux - [ ] MacOS (darwin) -- `multicast` version: +- `` version: >> `python3 -m pythonrepo.pythonrepo --version` diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index a3a7bea..4122280 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -2,7 +2,7 @@ name: Bug report about: Create a report to help us improve title: '' -labels: Bug, Failing +labels: Bug, Testing assignees: reactive-firewall --- @@ -26,11 +26,11 @@ If applicable, add logs here to help explain your problem. **Screenshots** _(optional)_ If applicable, add screenshots to help explain your problem. -**PiAP Device (please complete the following information):** +**Reporter's Device (please complete the following information):** - OS: [e.g. macOS] - OS Version: [e.g. 22] - Python Version [e.g. 3.9] _(optional)_ - - Python Template Version: [e.g. v0.5.0] + - Python Template Version: [e.g. v1.5.0] **Additional context** _(optional)_ Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/house-keeping.md b/.github/ISSUE_TEMPLATE/house-keeping.md new file mode 100644 index 0000000..68cdcde --- /dev/null +++ b/.github/ISSUE_TEMPLATE/house-keeping.md @@ -0,0 +1,23 @@ +--- +name: House Keeping +about: Create a suggestion to help improve a specific detail like depenancy version. +title: House Keeping +labels: Documentation, Github, Enhancement +assignees: '' + +--- + +**Describe the Task** +A clear and concise description of what needs done. +[e.g. library xyz should use the latest version 123] + +**Expected Solution** __(suggested)__ +A clear and concise description of what you (or others) might expect as a fix. +[e.g. update the version number to 123] + +**Related Documentation** __(optional)__ +If applicable, add documentation references to help explain your question. +[e.g. see link/to/librarry/version/123/docs] + +**Additional context** __(optional)__ +Add any other context about the question here. diff --git a/.github/labeler.yml b/.github/labeler.yml index 6d5a653..20faf9f 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -4,6 +4,8 @@ Python Repo: - any-glob-to-any-file: - setup.py - pythonrepo/*.py + - LICENSE + - LICENSE.md # Add 'Lint' label to any lint file changes Linter: diff --git a/docs/conf.py b/docs/conf.py index ae43ce2..14c7307 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -51,7 +51,7 @@ # The short X.Y version. version = 'v1.1' # The full version, including alpha/beta/rc tags. -release = 'v1.1.5' +release = 'v1.1.4' # The language for content autogenerated by Sphinx. Refer to documentation # for a list of supported languages. diff --git a/setup.cfg b/setup.cfg index 458a068..621fe9a 100644 --- a/setup.cfg +++ b/setup.cfg @@ -13,6 +13,9 @@ classifiers = Operating System :: POSIX :: Linux Programming Language :: Python Programming Language :: Python :: 3 + Programming Language :: Python :: 3.12 + Programming Language :: Python :: 3.11 + Programming Language :: Python :: 3.10 Programming Language :: Python :: 3.9 Programming Language :: Python :: 3.8 Programming Language :: Python :: 3.7 @@ -34,5 +37,5 @@ packages = find: [options.packages.find] exclude = - docs - tests + docs + tests diff --git a/setup.py b/setup.py index 862e023..ec81270 100755 --- a/setup.py +++ b/setup.py @@ -50,7 +50,7 @@ def readFile(filename): setup( name="""pythonrepo""", - version="""1.1.3""", + version="""1.1.4""", description="""Python Repo""", long_description=readme, install_requires=requirements, From e1159728587e6b8e8fee15aa47bcc887e00a96f1 Mon Sep 17 00:00:00 2001 From: "Mr. Walls" Date: Tue, 20 Aug 2024 16:14:39 -0700 Subject: [PATCH 2/2] Fixup for PR #60 to no-longer run python3.11 coverage twice in github CI (- Fixes #61 -) --- .github/workflows/Tests.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/Tests.yml b/.github/workflows/Tests.yml index 3306833..b850cbf 100644 --- a/.github/workflows/Tests.yml +++ b/.github/workflows/Tests.yml @@ -263,7 +263,7 @@ jobs: strategy: matrix: os: [ubuntu-latest, macos-13, windows-latest] - python-version: [3.7, 3.8, 3.9, "3.10", "3.11"] + python-version: [3.7, 3.8, 3.9, "3.10"] env: OS: ${{ matrix.os }} PYTHON_VERSION: ${{ matrix.python-version }} @@ -319,7 +319,6 @@ jobs: verbose: true fail_ci_if_error: false - name: Upload Python ${{ matrix.python-version }} Artifact - if: ${{ runner.python-version }} != "3.11" uses: actions/upload-artifact@v4 with: name: Test-Report-${{ matrix.os }}-${{ matrix.python-version }}