Skip to content

How to contribute #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 5, 2019
Merged

How to contribute #138

merged 15 commits into from
Mar 5, 2019

Conversation

operfildoluiz
Copy link

Segue novamente tradução da página "Como contribuir"

@netlify
Copy link

netlify bot commented Mar 1, 2019

Deploy preview for pt-br-reactjs ready!

Built with commit 7ed0a36

https://deploy-preview-138--pt-br-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Mar 1, 2019 •
edited
Loading

Deploy preview for pt-br-reactjs ready!

Built with commit 5c86b90

https://deploy-preview-138--pt-br-reactjs.netlify.com

jhonmike
jhonmike requested changes Mar 1, 2019
View reviewed changes
Copy link
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parabéns pela tradução ficou muito boa! Encontrei apenas pequenos detalhes com espaçamentos.

@operfildoluiz
Copy link
Author

@jhonmike

Procedi com as correções de typo, mas ainda sim concordo em manter pull request no feminino. Faz mais sentido, dada a tradução literal.

Branch, ramificação, feminino
Version, versão, masculino
Request, requisição, mudar pra masculino?

O que vcs acham?

@operfildoluiz operfildoluiz mentioned this pull request Mar 1, 2019
Closed
90 tasks
operfildoluiz
operfildoluiz commented Mar 1, 2019
View reviewed changes
Copy link
Author

@operfildoluiz operfildoluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Já corrigido, favor conferir :)

glaucia86
glaucia86 requested changes Mar 3, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhcgoncalves algumas alterações a serem realizadas. Pedimos que faça as alterações, por gentileza, que prontamente estaremos aprovando a sua excelente contribuição.

cc: @jhonmike @halian-vilela @eduardomoroni @cezaraugusto assim que o autor fizer as alterações necessárias listadas aqui, bastam aprovar direto essa PR. Li, linha por linha ;)

@glaucia86 glaucia86 added the needs author response Changes requested needing author's input label Mar 3, 2019
@tibuurcio tibuurcio mentioned this pull request Mar 3, 2019
Closed
13 tasks
glaucia86 and others added 10 commits March 3, 2019 15:07
@glaucia86
Update content/docs/how-to-contribute.md
e73b38a 
Co-Authored-By: lhcgoncalves <[email protected]>
@glaucia86
Update content/docs/how-to-contribute.md
ae78d75 
Co-Authored-By: lhcgoncalves <[email protected]>
@glaucia86
Update content/docs/how-to-contribute.md
d5d7424 
Co-Authored-By: lhcgoncalves <[email protected]>
@glaucia86
Update content/docs/how-to-contribute.md
1e87f62 
Co-Authored-By: lhcgoncalves <[email protected]>
@glaucia86
Update content/docs/how-to-contribute.md
b066c36 
Co-Authored-By: lhcgoncalves <[email protected]>
@glaucia86
Update content/docs/how-to-contribute.md
4ca135a 
Co-Authored-By: lhcgoncalves <[email protected]>
@glaucia86
Update content/docs/how-to-contribute.md
e22a1af 
Co-Authored-By: lhcgoncalves <[email protected]>
@glaucia86
Update content/docs/how-to-contribute.md
2ba5255 
Co-Authored-By: lhcgoncalves <[email protected]>
@glaucia86
Update content/docs/how-to-contribute.md
fbc0c41 
Co-Authored-By: lhcgoncalves <[email protected]>
@glaucia86
Update content/docs/how-to-contribute.md
73dc640 
Co-Authored-By: lhcgoncalves <[email protected]>
@operfildoluiz
Copy link
Author

Done!

@glaucia86
Copy link
Member

glaucia86 commented Mar 5, 2019 •
edited
Loading

@jhonmike

Procedi com as correções de typo, mas ainda sim concordo em manter pull request no feminino. Faz mais sentido, dada a tradução literal.

Branch, ramificação, feminino
Version, versão, masculino
Request, requisição, mudar pra masculino?

O que vcs acham?

Seguindo a documentação do Git em português, a palavra Pull Request está no masculino.

Link: https://git-scm.com/book/pt-br/v1/Git-Distribu%C3%ADdo-Contribuindo-Para-Um-Projeto

Pedimos encarecidamente que coloque no masculino. Seguindo o padrão de demais sites em português - incluso a própria documentação do Git para definição da palavra Pull Request que está no masculino.

cc: @halian-vilela @cezaraugusto @eduardomoroni @jhonmike deem uma olhada por favor na documentação do Git (no link acima), para que eu não possa comentar nenhum equívoco aqui ;)

@glaucia86
Copy link
Member

glaucia86 commented Mar 5, 2019 •
edited
Loading

Done!

@lhcgoncalves
Pedimos que altere para masculino a palavra Pull Request, conforme já mencionado acima. Senão, não aprovaremos a sua contribuição.

cc: @halian-vilela @jhonmike alterações a serem realizadas ainda pelo contribuidor. Não está done todavia!

@glaucia86 glaucia86 added the follow-up Changes applied in a previously translated file label Mar 5, 2019
@operfildoluiz
Copy link
Author

Ok, feito conforme vocês pediram.

@halian-vilela
Copy link
Collaborator

@lhcgoncalves

Boa tarde!

Seguindo o fluxo de comentários, as duas revisões e a finalização de todas as pendências, estou aprovando.

Valeu pela tradução!

cc: @glaucia86 @jhonmike

@halian-vilela halian-vilela merged commit ec4a934 into reactjs:master Mar 5, 2019
@halian-vilela halian-vilela added 🌐 translated Translation is completed for this page and removed follow-up Changes applied in a previously translated file needs author response Changes requested needing author's input labels Mar 5, 2019
@glaucia86
Copy link
Member

cc: @lhcgoncalves muito obrigada pela sua excelente Contribuição! 👍

@jhonmike
Copy link
Member

jhonmike commented Mar 6, 2019

Show 🏆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 requested changes

@jhonmike jhonmike jhonmike requested changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@operfildoluiz @glaucia86 @halian-vilela @jhonmike