This repository was archived by the owner on Jul 19, 2019. It is now read-only.
[fixed] Reset highlightedIndex when it's outside of items.length
#139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -60,6 +60,21 @@ describe('Autocomplete acceptance tests', () => { | |||
|
|
|||
| }); | |||
|
|
|||
| it('should reset `highlightedIndex` when `items` changes', () => { | |||
| autocompleteWrapper.setState({ highlightedIndex: 10 }); | |||
| autocompleteWrapper.setProps({ items: [] }) | |||
CMTegner
force-pushed
the
highlightedindex
branch
from
0d65177 to
987f738
Compare
This was referenced Jul 25, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this will resolve most of the funkyness we've been seeing when updating
itemson the fly while the user types, e.g. #52. /cc @sprjr