Skip to content

Commit 757092d

Browse files
committed
[SYCL] Fix queue command_graph namespace
- Remove sycl:: from command_graph namespace in queue - Improve comments
1 parent 2bcab93 commit 757092d

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

sycl/include/sycl/queue.hpp

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1085,18 +1085,22 @@ class __SYCL_EXPORT queue {
10851085

10861086
public:
10871087
/// Places the queue into command_graph recording mode.
1088-
/// Returns true if the queue was not already in recording mode.
1089-
bool begin_recording(
1090-
sycl::ext::oneapi::experimental::command_graph<
1091-
sycl::ext::oneapi::experimental::graph_state::modifiable> &graph);
1088+
///
1089+
/// \return true if the queue was not already in recording mode.
1090+
bool
1091+
begin_recording(ext::oneapi::experimental::command_graph<
1092+
ext::oneapi::experimental::graph_state::modifiable> &graph);
10921093

10931094
/// Ends recording mode on the queue and returns to the normal state.
1094-
/// Returns true if the queue was already in recording mode.
1095+
///
1096+
/// \return true if the queue was already in recording mode.
10951097
bool end_recording();
10961098

10971099
/// Submits an executable command_graph for execution on this queue
1098-
event submit(sycl::ext::oneapi::experimental::command_graph<
1099-
sycl::ext::oneapi::experimental::graph_state::executable>
1100+
///
1101+
/// \return an event representing the execution of the command_graph
1102+
event submit(ext::oneapi::experimental::command_graph<
1103+
ext::oneapi::experimental::graph_state::executable>
11001104
graph);
11011105

11021106
private:

sycl/source/queue.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,8 @@ bool queue::device_has(aspect Aspect) const {
216216
}
217217

218218
bool begin_recording(
219-
sycl::ext::oneapi::experimental::command_graph<
220-
sycl::ext::oneapi::experimental::graph_state::modifiable> &graph) {
219+
ext::oneapi::experimental::command_graph<
220+
ext::oneapi::experimental::graph_state::modifiable> &graph) {
221221
// Empty Implementation
222222
return true;
223223
}
@@ -227,10 +227,11 @@ bool end_recording() {
227227
return true;
228228
}
229229

230-
event submit(sycl::ext::oneapi::experimental::command_graph<
231-
sycl::ext::oneapi::experimental::graph_state::executable>
230+
event submit(ext::oneapi::experimental::command_graph<
231+
ext::oneapi::experimental::graph_state::executable>
232232
graph) {
233-
return sycl::event{};
233+
// Empty implementation
234+
return {};
234235
}
235236
} // __SYCL_INLINE_VER_NAMESPACE(_V1)
236237
} // namespace sycl

0 commit comments

Comments
 (0)