From 944641713bfce4715d76d954df29af65e54899aa Mon Sep 17 00:00:00 2001 From: shacharPash Date: Tue, 21 Mar 2023 16:01:04 +0200 Subject: [PATCH 1/2] change sismember returned value to int --- redis/client.py | 2 +- redis/commands/core.py | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/redis/client.py b/redis/client.py index 1a9b96b83d..7f514c383a 100755 --- a/redis/client.py +++ b/redis/client.py @@ -687,7 +687,7 @@ class AbstractRedis: **string_keys_to_dict( "AUTH COPY EXPIRE EXPIREAT PEXPIRE PEXPIREAT " "HEXISTS HMSET MOVE MSETNX PERSIST " - "PSETEX RENAMENX SISMEMBER SMOVE SETEX SETNX", + "PSETEX RENAMENX SMOVE SETEX SETNX", bool, ), **string_keys_to_dict( diff --git a/redis/commands/core.py b/redis/commands/core.py index e2cabb85fa..593507d1f1 100644 --- a/redis/commands/core.py +++ b/redis/commands/core.py @@ -3339,9 +3339,12 @@ def sinterstore( args = list_or_args(keys, args) return self.execute_command("SINTERSTORE", dest, *args) - def sismember(self, name: str, value: str) -> Union[Awaitable[bool], bool]: + def sismember(self, name: str, value: str) -> Union[Awaitable[Union[Literal[0],Literal[1]]], + Union[Literal[0], Literal[1]]]: """ - Return a boolean indicating if ``value`` is a member of set ``name`` + Return whether ``value`` is a member of set ``name``: + - 1 if the value is a member of the set. + - 0 if the value is not a member of the set or if key does not exist. For more information see https://redis.io/commands/sismember """ From a71d19cc21c1fae200e6c465618bb0b583caa86a Mon Sep 17 00:00:00 2001 From: shacharPash Date: Tue, 21 Mar 2023 17:01:09 +0200 Subject: [PATCH 2/2] fix linters --- redis/commands/core.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/redis/commands/core.py b/redis/commands/core.py index 593507d1f1..278188ecbd 100644 --- a/redis/commands/core.py +++ b/redis/commands/core.py @@ -3339,8 +3339,9 @@ def sinterstore( args = list_or_args(keys, args) return self.execute_command("SINTERSTORE", dest, *args) - def sismember(self, name: str, value: str) -> Union[Awaitable[Union[Literal[0],Literal[1]]], - Union[Literal[0], Literal[1]]]: + def sismember( + self, name: str, value: str + ) -> Union[Awaitable[Union[Literal[0], Literal[1]]], Union[Literal[0], Literal[1]]]: """ Return whether ``value`` is a member of set ``name``: - 1 if the value is a member of the set.