Add specs for rb_define_class_id_under

Author: ahmadsherif

optional/capi/class_spec.rb

@@ -4,6 +4,7 @@
 load_extension("class")
 
 autoload :ClassUnderAutoload, "#{object_path}/class_under_autoload_spec"
+autoload :ClassIdUnderAutoload, "#{object_path}/class_id_under_autoload_spec"
 
 describe :rb_path_to_class, shared: true do
   it "returns a class or module from a scoped String" do
@@ -245,6 +246,39 @@
     end
   end
 
+  describe "rb_define_class_id_under" do
+    it "creates a subclass of the superclass contained in a module" do
+      cls = @s.rb_define_class_id_under(CApiClassSpecs, :ClassIdUnder1, CApiClassSpecs::Super)
+      cls.should be_kind_of(Class)
+      CApiClassSpecs::Super.should be_ancestor_of(CApiClassSpecs::ClassIdUnder1)
+    end
+
+    it "uses Object as the superclass if NULL is passed" do
+      @s.rb_define_class_id_under(CApiClassSpecs, :ClassIdUnder2, nil)
+      Object.should be_ancestor_of(CApiClassSpecs::ClassIdUnder2)
+    end
+
+    it "sets the class name" do
+      cls = @s.rb_define_class_id_under(CApiClassSpecs, :ClassIdUnder3, nil)
+      cls.name.should == "CApiClassSpecs::ClassIdUnder3"
+    end
+
+    it "calls #inherited on the superclass" do
+      CApiClassSpecs::Super.should_receive(:inherited)
+      @s.rb_define_class_id_under(CApiClassSpecs, :ClassIdUnder4, CApiClassSpecs::Super)
+    end
+
+    it "defines a class for an existing Autoload" do
+      compile_extension("class_id_under_autoload")
+
+      ClassIdUnderAutoload.name.should == "ClassIdUnderAutoload"
+    end
+
+    it "raises a TypeError if class is defined and its superclass mismatches the given one" do
+      lambda { @s.rb_define_class_id_under(CApiClassSpecs, :Sub, nil) }.should raise_error(TypeError)
+    end
+  end
+
   describe "rb_define_class_variable" do
     it "sets a class variable" do
       o = CApiClassSpecs::CVars.new

optional/capi/ext/class_id_under_autoload_spec.c

@@ -0,0 +1,5 @@
+#include "ruby.h"
+
+void Init_class_id_under_autoload_spec(void) {
+  rb_define_class_id_under(rb_cObject, rb_intern("ClassIdUnderAutoload"), 0);
+}

optional/capi/ext/class_spec.c

@@ -148,6 +148,14 @@ static VALUE class_spec_rb_define_class_under(VALUE self, VALUE outer,
 }
 #endif
 
+#ifdef HAVE_RB_DEFINE_CLASS_ID_UNDER
+static VALUE class_spec_rb_define_class_id_under(VALUE self, VALUE outer,
+                                                 VALUE name, VALUE super) {
+  if(NIL_P(super)) super = 0;
+  return rb_define_class_id_under(outer, SYM2ID(name), super);
+}
+#endif
+
 #ifdef HAVE_RB_DEFINE_CLASS_VARIABLE
 static VALUE class_spec_define_class_variable(VALUE self, VALUE klass, VALUE name, VALUE val) {
   rb_define_class_variable(klass, StringValuePtr(name), val);
@@ -238,6 +246,10 @@ void Init_class_spec() {
   rb_define_method(cls, "rb_define_class_under", class_spec_rb_define_class_under, 3);
 #endif
 
+#ifdef HAVE_RB_DEFINE_CLASS_ID_UNDER
+  rb_define_method(cls, "rb_define_class_id_under", class_spec_rb_define_class_id_under, 3);
+#endif
+
 #ifdef HAVE_RB_DEFINE_CLASS_VARIABLE
   rb_define_method(cls, "rb_define_class_variable", class_spec_define_class_variable, 3);
 #endif

optional/capi/ext/rubyspec.h

@@ -394,6 +394,7 @@
 #define HAVE_RB_CONST_SET                  1
 #define HAVE_RB_DEFINE_ALIAS               1
 #define HAVE_RB_DEFINE_CLASS_UNDER         1
+#define HAVE_RB_DEFINE_CLASS_ID_UNDER      1
 #define HAVE_RB_DEFINE_CONST               1
 #define HAVE_RB_DEFINE_GLOBAL_CONST        1
 #define HAVE_RB_DEFINE_GLOBAL_FUNCTION     1