From b6426eef8dc66dbc1a5a312716183cba07b2bb30 Mon Sep 17 00:00:00 2001 From: WANG Rui Date: Fri, 1 Nov 2024 16:50:28 +0800 Subject: [PATCH 1/2] Disable `f16` for LoongArch64 Disable `f161` for LoongArch64 due to incorrect code generation on LLVM 19, which causes failures in `testcrate/tests/conv.rs`. This workaround will remain in place until llvm/llvm-project#109093 is merged or we upgrade to LLVM 20. --- configure.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure.rs b/configure.rs index e23c0e839..bb475b697 100644 --- a/configure.rs +++ b/configure.rs @@ -64,6 +64,8 @@ pub fn configure_f16_f128(target: &Target) { "arm64ec" => (false, false), // `f16` crashes "s390x" => (false, true), + // `f16` test failures + "loongarch64" => (false, true), // `f128` crashes "mips64" | "mips64r6" => (true, false), // `f128` crashes From 9da50f36aad8d4eafd36b0d9e98974d109ae7426 Mon Sep 17 00:00:00 2001 From: Trevor Gross Date: Fri, 1 Nov 2024 04:53:39 -0500 Subject: [PATCH 2/2] Update configure.rs --- configure.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.rs b/configure.rs index bb475b697..68b4d68e6 100644 --- a/configure.rs +++ b/configure.rs @@ -64,7 +64,7 @@ pub fn configure_f16_f128(target: &Target) { "arm64ec" => (false, false), // `f16` crashes "s390x" => (false, true), - // `f16` test failures + // FIXME(llvm): `f16` test failures fixed by "loongarch64" => (false, true), // `f128` crashes "mips64" | "mips64r6" => (true, false),