diff --git a/.travis.yml b/.travis.yml index e1ced372fb3..98b8be05568 100644 --- a/.travis.yml +++ b/.travis.yml @@ -21,7 +21,7 @@ env: - PERCY_PROJECT=crates-io/crates.io - PGPORT=5433 - PATH=$HOME/.cargo/bin:$PATH - - RUSTFLAGS="-C debuginfo=0" + - RUSTFLAGS="-C debuginfo=0 -D warnings" install: - sudo cp /etc/postgresql/10/main/pg_hba.conf /etc/postgresql/11/main/pg_hba.conf diff --git a/src/bin/background-worker.rs b/src/bin/background-worker.rs index cc8e06ddb3e..ada1edfd123 100644 --- a/src/bin/background-worker.rs +++ b/src/bin/background-worker.rs @@ -10,7 +10,7 @@ //! Usage: //! cargo run --bin background-worker -#![deny(warnings, clippy::all, rust_2018_idioms)] +#![warn(clippy::all, rust_2018_idioms)] use cargo_registry::git::{Repository, RepositoryConfig}; use cargo_registry::{background_jobs::*, db}; diff --git a/src/bin/delete-crate.rs b/src/bin/delete-crate.rs index 07a6b29f6bd..2875aeddd57 100644 --- a/src/bin/delete-crate.rs +++ b/src/bin/delete-crate.rs @@ -5,7 +5,7 @@ // Usage: // cargo run --bin delete-crate crate-name -#![deny(warnings, clippy::all, rust_2018_idioms)] +#![warn(clippy::all, rust_2018_idioms)] use cargo_registry::{db, models::Crate, schema::crates}; use std::{ diff --git a/src/bin/delete-version.rs b/src/bin/delete-version.rs index d612b3129fb..e15a5152861 100644 --- a/src/bin/delete-version.rs +++ b/src/bin/delete-version.rs @@ -5,7 +5,7 @@ // Usage: // cargo run --bin delete-version crate-name version-number -#![deny(warnings, clippy::all, rust_2018_idioms)] +#![warn(clippy::all, rust_2018_idioms)] use cargo_registry::{ db, diff --git a/src/bin/monitor.rs b/src/bin/monitor.rs index 182330fb6e4..cfc5d6231d4 100644 --- a/src/bin/monitor.rs +++ b/src/bin/monitor.rs @@ -4,7 +4,7 @@ //! Usage: //! cargo run --bin monitor -#![deny(warnings, clippy::all, rust_2018_idioms)] +#![warn(clippy::all, rust_2018_idioms)] mod on_call; diff --git a/src/bin/populate.rs b/src/bin/populate.rs index f45776cc575..bd2f990f378 100644 --- a/src/bin/populate.rs +++ b/src/bin/populate.rs @@ -4,7 +4,7 @@ // Usage: // cargo run --bin populate version_id1 version_id2 ... -#![deny(warnings, clippy::all, rust_2018_idioms)] +#![warn(clippy::all, rust_2018_idioms)] use cargo_registry::{db, schema::version_downloads}; use std::env; diff --git a/src/bin/render-readmes.rs b/src/bin/render-readmes.rs index ac2ca7df165..63988289c01 100644 --- a/src/bin/render-readmes.rs +++ b/src/bin/render-readmes.rs @@ -3,7 +3,7 @@ // // Warning: this can take a lot of time. -#![deny(warnings, clippy::all, rust_2018_idioms)] +#![warn(clippy::all, rust_2018_idioms)] #[macro_use] extern crate serde; diff --git a/src/bin/server.rs b/src/bin/server.rs index 3871f9f6c53..dba9ab7209c 100644 --- a/src/bin/server.rs +++ b/src/bin/server.rs @@ -1,4 +1,4 @@ -#![deny(warnings, clippy::all, rust_2018_idioms)] +#![warn(clippy::all, rust_2018_idioms)] use cargo_registry::{boot, App, Env}; use std::{ diff --git a/src/bin/test-pagerduty.rs b/src/bin/test-pagerduty.rs index 12055fbe126..88fda8f4fd8 100644 --- a/src/bin/test-pagerduty.rs +++ b/src/bin/test-pagerduty.rs @@ -5,7 +5,7 @@ //! //! Event type can be trigger, acknowledge, or resolve -#![deny(warnings, clippy::all, rust_2018_idioms)] +#![warn(clippy::all, rust_2018_idioms)] mod on_call; diff --git a/src/bin/transfer-crates.rs b/src/bin/transfer-crates.rs index 527937f9feb..e56916af3d1 100644 --- a/src/bin/transfer-crates.rs +++ b/src/bin/transfer-crates.rs @@ -3,7 +3,7 @@ // Usage: // cargo run --bin transfer-crates from-user to-user -#![deny(warnings, clippy::all, rust_2018_idioms)] +#![warn(clippy::all, rust_2018_idioms)] use cargo_registry::{ db, diff --git a/src/email.rs b/src/email.rs index dbf7ae7bf51..d4f6af7f605 100644 --- a/src/email.rs +++ b/src/email.rs @@ -43,7 +43,6 @@ fn build_email( .map(|s| s.smtp_login.as_str()) .unwrap_or("test@localhost"); - #[allow(clippy::redundant_closure)] let email = Email::builder() .to(recipient) .from(sender) diff --git a/src/lib.rs b/src/lib.rs index ec774e4dab2..d18d80d9239 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -3,10 +3,9 @@ //! All implemented routes are defined in the [middleware](fn.middleware.html) function and //! implemented in the [category](category/index.html), [keyword](keyword/index.html), //! [krate](krate/index.html), [user](user/index.html) and [version](version/index.html) modules. -#![deny(warnings, clippy::all, rust_2018_idioms)] -#![deny(missing_debug_implementations, missing_copy_implementations)] -#![deny(bare_trait_objects)] -#![recursion_limit = "256"] + +#![warn(clippy::all, rust_2018_idioms)] +#![warn(missing_debug_implementations, missing_copy_implementations)] #[macro_use] extern crate derive_deref; diff --git a/src/models/version.rs b/src/models/version.rs index e685967e1a9..a30235c9d6c 100644 --- a/src/models/version.rs +++ b/src/models/version.rs @@ -129,7 +129,6 @@ impl Version { } impl NewVersion { - #[allow(clippy::new_ret_no_self)] pub fn new( crate_id: i32, num: &semver::Version, diff --git a/src/s3/lib.rs b/src/s3/lib.rs index 36e040748fc..6b99ed57163 100644 --- a/src/s3/lib.rs +++ b/src/s3/lib.rs @@ -1,4 +1,4 @@ -#![deny(warnings, clippy::all, rust_2018_idioms)] +#![warn(clippy::all, rust_2018_idioms)] extern crate base64; extern crate chrono; diff --git a/src/tests/all.rs b/src/tests/all.rs index 5ede0328de8..05b213024e8 100644 --- a/src/tests/all.rs +++ b/src/tests/all.rs @@ -1,10 +1,4 @@ -#![deny(warnings, clippy::all, rust_2018_idioms)] -// TODO: Remove after we can bump to Rust 1.35 stable in `RustConfig` -#![allow( - renamed_and_removed_lints, - clippy::cyclomatic_complexity, - clippy::unknown_clippy_lints -)] +#![warn(clippy::all, rust_2018_idioms)] #[macro_use] extern crate diesel; diff --git a/src/tests/krate.rs b/src/tests/krate.rs index accaa6579c2..5559af1dd80 100644 --- a/src/tests/krate.rs +++ b/src/tests/krate.rs @@ -1505,7 +1505,6 @@ fn yank_by_a_non_owner_fails() { } #[test] -#[allow(clippy::cognitive_complexity)] fn yank_max_version() { let (_, anon, _, token) = TestApp::full().with_token();