Skip to content

Account for core_threads when setting up background threads #2529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 26, 2020

Conversation

jtgeibel
Copy link
Member

The number of core_threads counts against the max_threads setting. For
parity with the thread count enforced by civet, the core thread count
is added to SERVER_THREADS when setting the max thread count.

r? @JohnTitor

The number of core_threads counts against the max_threads setting. For
parity with the thread count enforced by `civet`, the core thread count
is added to `SERVER_THREADS` when setting the max thread count.
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 26, 2020

📌 Commit e373e12 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented May 26, 2020

⌛ Testing commit e373e12 with merge 8e9baef...

@bors
Copy link
Contributor

bors commented May 26, 2020

☀️ Test successful - checks-travis
Approved by: JohnTitor
Pushing 8e9baef to master...

@bors bors merged commit 8e9baef into rust-lang:master May 26, 2020
@jtgeibel jtgeibel deleted the fix-blocking-thread-count branch September 20, 2020 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants