Skip to content

Commit 33f6bda

Browse files
jyn514Joshua Nelson
authored andcommitted
Link to documentation, not to /crate on homepage
1 parent 69215ad commit 33f6bda

File tree

2 files changed

+24
-4
lines changed

2 files changed

+24
-4
lines changed

src/web/releases.rs

Lines changed: 23 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1035,13 +1035,33 @@ mod tests {
10351035
let web = env.frontend();
10361036
assert_success("/", web)?;
10371037

1038-
env.db().fake_release().name("some_random_crate").create()?;
10391038
env.db()
10401039
.fake_release()
1041-
.name("some_random_crate_that_failed")
1040+
.name("crate_that_succeeded")
1041+
.version("0.1.0")
1042+
.create()?;
1043+
env.db()
1044+
.fake_release()
1045+
.name("crate_that_failed")
1046+
.version("0.1.0")
10421047
.build_result_successful(false)
10431048
.create()?;
1044-
assert_success("/", web)
1049+
let home_page = kuchiki::parse_html().one(web.get("/").send()?.text()?);
1050+
let releases: Vec<_> = home_page
1051+
.select("a.release")
1052+
.expect("missing heading")
1053+
.collect();
1054+
assert_eq!(2, releases.len(), "expected 2 releases");
1055+
for release in releases {
1056+
let attributes = release.attributes.borrow();
1057+
let url = attributes.get("href").unwrap();
1058+
if url.contains("crate_that_succeeded") {
1059+
assert_eq!(url, "/crate_that_succeeded/0.1.0/crate_that_succeeded");
1060+
} else {
1061+
assert_eq!(url, "/crate/crate_that_failed/0.1.0");
1062+
}
1063+
}
1064+
Ok(())
10451065
})
10461066
}
10471067

tera-templates/core/home.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ <h1 class="brand"><i class="fa fa-cubes fa-fw"></i> Docs.rs</h1>
3434

3535
<ul>
3636
{%- for release in recent_releases -%}
37-
{%- if rustdoc_status -%}
37+
{%- if release.rustdoc_status -%}
3838
{%- set release_url = "/" ~ release.name ~ "/" ~ release.version ~ "/" ~ release.target_name -%}
3939
{%- else -%}
4040
{%- set release_url = "/crate/" ~ release.name ~ "/" ~ release.version -%}

0 commit comments

Comments
 (0)