Skip to content

Commit 3658155

Browse files
KixironJoshua Nelson
authored andcommitted
Renamed build_log and made the builds page use comments over shell cmds
1 parent 43a358f commit 3658155

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

src/web/builds.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ pub(crate) struct Build {
2828
struct BuildsPage {
2929
metadata: Option<MetaData>,
3030
builds: Vec<Build>,
31-
build_log: Option<Build>,
31+
build_details: Option<Build>,
3232
limits: Limits,
3333
}
3434

@@ -68,7 +68,7 @@ pub fn build_list_handler(req: &mut Request) -> IronResult<Response> {
6868
)
6969
);
7070

71-
let mut build_log = None;
71+
let mut build_details = None;
7272
// FIXME: getting builds.output may cause performance issues when release have tons of builds
7373
let mut builds = query
7474
.into_iter()
@@ -85,7 +85,7 @@ pub fn build_list_handler(req: &mut Request) -> IronResult<Response> {
8585
};
8686

8787
if id == req_build_id {
88-
build_log = Some(build.clone());
88+
build_details = Some(build.clone());
8989
}
9090

9191
build
@@ -113,7 +113,7 @@ pub fn build_list_handler(req: &mut Request) -> IronResult<Response> {
113113
BuildsPage {
114114
metadata: MetaData::from_crate(&conn, &name, &version),
115115
builds,
116-
build_log,
116+
build_details,
117117
limits,
118118
}
119119
.into_response(req)

templates/crate/builds.html

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,19 +14,20 @@
1414
<div class="recent-releases-container">
1515
{# If there is a build log then show it #}
1616
{# TODO: When viewing a build log, show a back button or a hide button #}
17-
{%- if build_log -%}
17+
{%- if build_details -%}
1818
<div class="release">
19-
<strong>Build #{{ build_log.id }} {{ build_log.build_time | date(format="%+") }}</strong>
19+
<strong>Build #{{ build_details.id }} {{ build_details.build_time | date(format="%+") }}</strong>
2020
</div>
2121

2222
{%- filter dedent -%}
2323
<pre>
24-
$ rustc --version
25-
{{ build_log.rustc_version }}
26-
$ docsrs --version
27-
{{ build_log.docsrs_version }}
28-
$ docsrs ...
29-
{{ build_log.output }}
24+
# rustc version
25+
{{ build_details.rustc_version }}
26+
# docs.rs version
27+
{{ build_details.docsrs_version }}
28+
29+
# build log
30+
{{ build_details.output }}
3031
</pre>
3132
{%- endfilter -%}
3233
{%- endif -%}

0 commit comments

Comments
 (0)