tests: Add lsif_contains_generated_constant test
#18309
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Urhengulas
force-pushed
the
test-lsif_contains_generated_macros
branch
from
2a96039 to
31b11e0
Compare
Urhengulas
changed the title
lsif_contains_generated_macros testlsif_contains_generated_constant test
Urhengulas
force-pushed
the
test-lsif_contains_generated_macros
branch
from
babbd7e to
217ff18
Compare
Urhengulas
force-pushed
the
test-lsif_contains_generated_macros
branch
from
217ff18 to
cd5559f
Compare
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Oct 29, 2024
…macros, r=lnicola tests: Add `lsif_contains_generated_constant` test Closes rust-lang/rust-analyzer#18309
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 9, 2024
…=lnicola tests: Add `lsif_contains_generated_constant` test Closes rust-lang/rust-analyzer#18309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an upcoming open-source requirements-test-tracing tool
cargo-needywe utilize therust-analyzer lsifcommand to extract information about constants generated by a proc-macro. We would like to contribute a test which ensures that the command keeps containing that information.We obviously would like the behavior we rely on to be kept, but we understand that it might change due to other goals. In this case we would kindly ask to inform us by opening a ticket at https://github.com/ferrocene/needy (not public yet, but soon!).
Note
Regarding the change in
.gitignore: By removing the leading slash in the first line all target directories in the repository are gonna be ignored. If you would like to keep the previous version, I will have to add a.gitignoreto thelsif-test-crate.