remove first outer iteration and unnecessary variable

Author: jonboh

clippy_lints/src/item_name_repetitions.rs

@@ -209,19 +209,13 @@ fn check_fields(cx: &LateContext<'_>, threshold: u64, fields: &[FieldDef<'_>], i
         }
     }
 
-    let mut pre = match fields.get(0) {
-        Some(first_field) => {
-            let words: Vec<&str> = first_field.ident.name.as_str().split('_').collect();
-            if words.len() == 1 {
-                return;
-            }
-            words
-        },
+    let mut pre: Vec<&str> = match fields.get(0) {
+        Some(first_field) => first_field.ident.name.as_str().split('_').collect(),
         None => return,
     };
     let mut post = pre.clone();
     post.reverse();
-    for field in fields.iter().skip(1) {
+    for field in fields {
         let field_split: Vec<&str> = field.ident.name.as_str().split('_').collect();
         if field_split.len() == 1 {
             return;
@@ -432,8 +426,6 @@ impl LateLintPass<'_> for ItemNameRepetitions {
                 }
             }
         }
-        let item_name = item.ident.name.as_str();
-
         if !(self.avoid_breaking_exported_api && cx.effective_visibilities.is_exported(item.owner_id.def_id)) {
             match item.kind {
                 ItemKind::Enum(def, _) => check_variant(cx, self.threshold, &def, item_name, item.span),