From 10f86b5a27f3cf341b5ce179f1717e2258d083f5 Mon Sep 17 00:00:00 2001
From: Stefan Plantikow <stefan.plantikow@googlemail.com>
Date: Tue, 22 Nov 2011 18:08:26 +0100
Subject: [PATCH 1/5] std: rewrote math to support most C95 libmath calls on
 f32, f64 and float

---
 src/lib/ctypes.rs        |   4 +
 src/lib/math.rs          | 353 ++++++++++++++++++++++++++++++++-------
 src/test/stdtest/math.rs |  12 +-
 3 files changed, 305 insertions(+), 64 deletions(-)

diff --git a/src/lib/ctypes.rs b/src/lib/ctypes.rs
index c48a2c8c073b1..890300ce78124 100644
--- a/src/lib/ctypes.rs
+++ b/src/lib/ctypes.rs
@@ -5,6 +5,7 @@ Definitions useful for C interop
 */
 
 type c_int = i32;
+
 type long = int;
 type unsigned = u32;
 type ulong = uint;
@@ -13,6 +14,9 @@ type intptr_t = uint;
 type uintptr_t = uint;
 type uint32_t = u32;
 
+// This *must* match with "import c_float = fXX" in std::math per arch
+type c_float = f64;
+
 type size_t = uint;
 type ssize_t = int;
 type off_t = uint;
diff --git a/src/lib/math.rs b/src/lib/math.rs
index 5d826d5ce321d..339e63086515e 100644
--- a/src/lib/math.rs
+++ b/src/lib/math.rs
@@ -1,125 +1,362 @@
 /* Module: math */
 
-#[link_name = ""]
+export consts;
+export min, max;
+
+export f32, f64;
+
+// Currently this module supports from -lmath
+// C95 - frexp - ldexp - fmod - modf + log2 + log1p
+
+export
+    acos, asin, atan, atan2, ceil, cos, cosh, exp, abs, floor,
+    ln, ln1p, log10, log2, pow, sin, sinh, sqrt, tan, tanh;
+
+// These two must match in width according to architecture
+
+import ctypes::c_float;
+import c_float = f64;
+
+
+#[link_name = "m"]
 #[abi = "cdecl"]
-native mod libc {
-    fn sqrt(n: float) -> float;
-    fn sin(n: float) -> float;
-    fn asin(n: float) -> float;
-    fn cos(n: float) -> float;
-    fn acos(n: float) -> float;
-    fn tan(n: float) -> float;
-    fn atan(n: float) -> float;
-    #[link_name="log"]
-    fn ln(n: float) -> float;
-    fn log2(n: float) -> float;
-    fn log10(n: float) -> float;
-    fn log1p(n: float) -> float;
+native mod f64 {
+
+    // Alpabetically sorted by link_name
+
+    fn acos(n: f64) -> f64;
+    fn asin(n: f64) -> f64;
+    fn atan(n: f64) -> f64;
+    fn atan2(a: f64, b: f64) -> f64;
+    fn ceil(n: f64) -> f64;
+    fn cos(n: f64) -> f64;
+    fn cosh(n: f64) -> f64;
+    fn exp(n: f64) -> f64;
+    #[link_name="fabs"] fn abs(n: f64) -> f64; 
+    fn floor(n: f64) -> f64;
+    #[link_name="log"] fn ln(n: f64) -> f64;
+    #[link_name="log1p"] fn ln1p(n: f64) -> f64;
+    fn log10(n: f64) -> f64;
+    fn log2(n: f64) -> f64;
+    fn pow(n: f64, e: f64) -> f64;
+    fn sin(n: f64) -> f64;
+    fn sinh(n: f64) -> f64;
+    fn sqrt(n: f64) -> f64;
+    fn tan(n: f64) -> f64;
+    fn tanh(n: f64) -> f64;
+}
+
+#[link_name = "m"]
+#[abi = "cdecl"]
+native mod f32 {
+
+    // Alpabetically sorted by link_name
+
+    #[link_name="acosf"] fn acos(n: f32) -> f32;
+    #[link_name="asinf"] fn asin(n: f32) -> f32;
+    #[link_name="atanf"] fn atan(n: f32) -> f32;
+    #[link_name="atan2f"] fn atan2(a: f32, b: f32) -> f32;
+    #[link_name="ceilf"] fn ceil(n: f32) -> f32;
+    #[link_name="cosf"] fn cos(n: f32) -> f32;
+    #[link_name="coshf"] fn cosh(n: f32) -> f32;
+    #[link_name="expf"] fn exp(n: f32) -> f32;
+    #[link_name="fabsf"] fn abs(n: f32) -> f32;
+    #[link_name="floorf"] fn floor(n: f32) -> f32;
+    #[link_name="powf"] fn pow(n: f32, e: f32) -> f32;
+    #[link_name="sinf"] fn sin(n: f32) -> f32;
+    #[link_name="sinhf"] fn sinh(n: f32) -> f32;
+    #[link_name="sqrtf"] fn sqrt(n: f32) -> f32;
+    #[link_name="tanf"] fn tan(n: f32) -> f32;
+    #[link_name="tanhf"] fn tanh(n: f32) -> f32;
+    #[link_name="logf"] fn ln(n: f32) -> f32;
+    #[link_name="log1p"] fn ln1p(n: f64) -> f64;
+    #[link_name="log2f"] fn log2(n: f32) -> f32;
+    #[link_name="log10f"] fn log10(n: f32) -> f32;
+}
+
+
+mod consts {
+    /*
+    Const: pi
+
+    Archimedes' constant
+    */
+    const pi: float = 3.14159265358979323846264338327950288;
+
+    /*
+    Const: frac_pi_2
+
+    pi/2.0
+    */
+    const frac_pi_2: float = 1.57079632679489661923132169163975144;
+
+    /*
+    Const: frac_pi_4
+
+    pi/4.0
+    */
+    const frac_pi_4: float = 0.785398163397448309615660845819875721;
+
+    /*
+    Const: frac_1_pi
+
+    1.0/pi
+    */
+    const frac_1_pi: float = 0.318309886183790671537767526745028724;
+
+    /*
+    Const: frac_2_pi
+
+    2.0/pi
+    */
+    const frac_2_pi: float = 0.636619772367581343075535053490057448;
+
+    /*
+    Const: frac_2_sqrtpi
+
+    2.0/sqrt(pi)
+    */
+    const frac_2_sqrtpi: float = 1.12837916709551257389615890312154517;
+
+    /*
+    Const: sqrt2
+
+    sqrt(2.0)
+    */
+    const sqrt2: float = 1.41421356237309504880168872420969808;
+
+    /*
+    Const: frac_1_sqrt2
+
+    1.0/sqrt(2.0)
+    */
+    const frac_1_sqrt2: float = 0.707106781186547524400844362104849039;
+
+    /*
+    Const: e
+
+    Euler's number
+    */
+    const e: float = 2.71828182845904523536028747135266250;
+
+    /*
+    Const: log2_e
+
+    log2(e)
+    */
+    const log2_e: float = 1.44269504088896340735992468100189214;
+
+    /*
+    Const: log10_e
+
+    log10(e)
+    */
+    const log10_e: float = 0.434294481903251827651128918916605082;
+
+    /*
+    Const: ln_2
+
+    ln(2.0)
+    */
+    const ln_2: float = 0.693147180559945309417232121458176568;
+
+    /*
+    Const: ln_10
+
+    ln(10.0)
+    */
+    const ln_10: float = 2.30258509299404568401799145468436421;
+
 }
 
 /*
-Function: sqrt
+Function: min
 
-Returns the square root
+Returns the minimum of two values
 */
-pure fn sqrt(x: float) -> float { unsafe { libc::sqrt(x) } }
+pure fn min<copy T>(x: T, y: T) -> T { x < y ? x : y }
 
 /*
-Function: sin
+Function: max
 
-Returns the sine of an angle
+Returns the maximum of two values
 */
-pure fn sin(x: float) -> float { unsafe { libc::sin(x) } }
+pure fn max<copy T>(x: T, y: T) -> T { x < y ? y : x }
 
 /*
-Function: cos
+Function: acos
 
-Returns the cosine of an angle
+Returns the arccosine of an angle (measured in rad)
 */
-pure fn cos(x: float) -> float { unsafe { libc::cos(x) } }
+pure fn acos(x: float) -> float
+    { unsafe { c_float::acos(x as c_float) as float } }
 
 /*
-Function: tan
+Function: asin
 
-Returns the tangent of an angle
+Returns the arcsine of an angle (measured in rad)
 */
-pure fn tan(x: float) -> float { unsafe { libc::tan(x) } }
+pure fn asin(x: float) -> float
+    { unsafe { c_float::asin(x as c_float) as float } }
 
 /*
-Function: asin
+Function: atan
 
-Returns the arcsine of an angle
+Returns the arctangents of an angle (measured in rad)
 */
-pure fn asin(x: float) -> float { unsafe { libc::asin(x) } }
+pure fn atan(x: float) -> float
+    { unsafe { c_float::atan(x as c_float) as float } }
+
 
 /*
-Function: acos
+Function: atan2
 
-Returns the arccosine of an angle
+Returns the arctangent of an angle (measured in rad)
 */
-pure fn acos(x: float) -> float { unsafe { libc::acos(x) } }
+pure fn atan2(y: float, x: float) -> float
+    { unsafe { c_float::atan2(y as c_float, x as c_float) as float } }
 
 /*
-Function: atan
+Function: ceil
 
-Returns the arctangent of an angle
+Returns:
+
+The smallest integral value less than or equal to `n`
 */
-pure fn atan(x: float) -> float { unsafe { libc::atan(x) } }
+pure fn ceil(n: float) -> float
+    { unsafe { c_float::ceil(n as c_float) as float } }
 
 /*
-Const: pi
+Function: cos
 
-Archimedes' constant
+Returns the cosine of an angle `x` (measured in rad)
 */
-const pi: float = 3.141592653589793;
+pure fn cos(x: float) -> float
+    { unsafe { c_float::cos(x as c_float) as float } }
 
 /*
-Function: min
+Function: cosh
+
+Returns the hyperbolic cosine of `x`
 
-Returns the minimum of two values
 */
-pure fn min<copy T>(x: T, y: T) -> T { x < y ? x : y }
+pure fn cosh(x: float) -> float
+    { unsafe { c_float::cosh(x as c_float) as float } }
+
 
 /*
-Function: max
+Function: exp
 
-Returns the maximum of two values
+Returns:
+
+e to the power of `n*
 */
-pure fn max<copy T>(x: T, y: T) -> T { x < y ? y : x }
+pure fn exp(n: float) -> float
+    { unsafe { c_float::exp(n as c_float) as float } }
+
+/*
+Function: abs
+
+Returns:
+
+The absolute value of  `n`
+
+*/
+pure fn abs(n: float) -> float
+    { unsafe { c_float::abs(n as c_float) as float } }
 
 /*
-Const: e
+Function: floor
+
+Returns:
 
-Euler's number
+The largest integral value less than or equal to `n`
 */
-const e: float = 2.718281828459045235;
+pure fn floor(n: float) -> float
+    { unsafe { c_float::floor(n as c_float) as float } }
 
 /*
 Function: ln
 
-Returns the natural logaritm
+Returns the natural logaritm of `n`
 */
-pure fn ln(n: float) -> float { unsafe { libc::ln(n) } }
+pure fn ln(n: float) -> float
+    { unsafe { c_float::ln(n as c_float) as float } }
 
 /*
-Function: log2
+Function: ln1p
+
+Returns the natural logarithm of `1+n` accurately,
+even for very small values of `n`
+*/
+pure fn ln1p(n: float) -> float
+    { unsafe { c_float::ln1p(n as c_float) as float } }
+
+/*
+Function: log10
 
-Returns the logarithm to base 2
+Returns the logarithm to base 10 of `n`
 */
-pure fn log2(n: float) -> float { unsafe { libc::log2(n) } }
+pure fn log10(n: float) -> float
+    { unsafe { c_float::log10(n as c_float) as float } }
 
 /*
 Function: log2
 
-Returns the logarithm to base 10
+Returns the logarithm to base 2 of `n`
+*/
+pure fn log2(n: float) -> float
+    { unsafe { c_float::log2(n as c_float) as float } }
+
+/*
+Function: pow
 */
-pure fn log10(n: float) -> float { unsafe { libc::log10(n) } }
+pure fn pow(v: float, e: float) -> float
+    { unsafe { c_float::pow(v as c_float, e as c_float) as float } }
 
 
 /*
-Function: log1p
+Function: sin
 
-Returns the natural logarithm of `1+n` accurately,
-even for very small values of `n`
+Returns the sine of an angle `x` (measured in rad)
+*/
+pure fn sin(x: float) -> float
+    { unsafe { c_float::sin(x as c_float) as float } }
+
+/*
+Function: sinh
+
+Returns the hyperbolic sine of an angle `x` (measured in rad)
 */
-pure fn ln1p(n: float) -> float { unsafe { libc::log1p(n) } }
+pure fn sinh(x: float) -> float
+    { unsafe { c_float::sinh(x as c_float) as float } }
+
+/*
+Function: sqrt
+
+Returns the square root of `x`
+*/
+pure fn sqrt(x: float) -> float
+    { unsafe { c_float::sqrt(x as c_float) as float } }
+
+/*
+Function: tan
+
+Returns the tangent of an angle `x` (measured in rad)
+
+*/
+pure fn tan(x: float) -> float
+    { unsafe { c_float::tan(x as c_float) as float } }
+
+/*
+Function: tanh
+
+Returns the hyperbolic tangent of an angle `x` (measured in rad)
+
+*/
+pure fn tanh(x: float) -> float
+    { unsafe { c_float::tanh(x as c_float) as float } }
+
+
+
+
diff --git a/src/test/stdtest/math.rs b/src/test/stdtest/math.rs
index 12bc31bb0e5b9..53d93ae3077ac 100644
--- a/src/test/stdtest/math.rs
+++ b/src/test/stdtest/math.rs
@@ -24,14 +24,14 @@ fn test_max_min() {
 fn test_angle() {
     fn angle(vec: (float, float)) -> float {
         alt vec {
-          (0f, y) when y < 0f { 1.5 * std::math::pi }
-          (0f, y) { 0.5 * std::math::pi }
+          (0f, y) when y < 0f { 1.5 * consts::pi }
+          (0f, y) { 0.5 * consts::pi }
           (x, y) { std::math::atan(y / x) }
         }
     }
     assert angle((1f, 0f)) == 0f;
-    assert angle((1f, 1f)) == 0.25 * pi;
-    assert angle((0f, 1f)) == 0.5 * pi;
+    assert angle((1f, 1f)) == 0.25 * consts::pi;
+    assert angle((0f, 1f)) == 0.5 * consts::pi;
 }
 
 
@@ -42,11 +42,11 @@ fn test_log_functions() {
     assert log2(1.0) == 0.0;
     assert log10(1.0) == 0.0;
 
-    assert ln(e) == 1.0;
+    assert ln(consts::e) == 1.0;
     assert log2(2.0) == 1.0;
     assert log10(10.0) == 1.0;
 
-    assert ln(e*e*e*e) == 4.0;
+    assert ln(consts::e*consts::e*consts::e*consts::e) == 4.0;
     assert log2(256.0) == 8.0;
     assert log10(1000.0) == 3.0;
 

From 68633e58d7e3b20788bf381b77a54af10f5167ab Mon Sep 17 00:00:00 2001
From: Stefan Plantikow <stefan.plantikow@googlemail.com>
Date: Tue, 22 Nov 2011 20:03:37 +0100
Subject: [PATCH 2/5] std: math now declares libm dependencies as pure

---
 src/lib/math.rs | 120 ++++++++++++++++++++++++------------------------
 1 file changed, 60 insertions(+), 60 deletions(-)

diff --git a/src/lib/math.rs b/src/lib/math.rs
index 339e63086515e..060d0b1cbb341 100644
--- a/src/lib/math.rs
+++ b/src/lib/math.rs
@@ -24,26 +24,26 @@ native mod f64 {
 
     // Alpabetically sorted by link_name
 
-    fn acos(n: f64) -> f64;
-    fn asin(n: f64) -> f64;
-    fn atan(n: f64) -> f64;
-    fn atan2(a: f64, b: f64) -> f64;
-    fn ceil(n: f64) -> f64;
-    fn cos(n: f64) -> f64;
-    fn cosh(n: f64) -> f64;
-    fn exp(n: f64) -> f64;
-    #[link_name="fabs"] fn abs(n: f64) -> f64; 
-    fn floor(n: f64) -> f64;
-    #[link_name="log"] fn ln(n: f64) -> f64;
-    #[link_name="log1p"] fn ln1p(n: f64) -> f64;
-    fn log10(n: f64) -> f64;
-    fn log2(n: f64) -> f64;
-    fn pow(n: f64, e: f64) -> f64;
-    fn sin(n: f64) -> f64;
-    fn sinh(n: f64) -> f64;
-    fn sqrt(n: f64) -> f64;
-    fn tan(n: f64) -> f64;
-    fn tanh(n: f64) -> f64;
+    pure fn acos(n: f64) -> f64;
+    pure fn asin(n: f64) -> f64;
+    pure fn atan(n: f64) -> f64;
+    pure fn atan2(a: f64, b: f64) -> f64;
+    pure fn ceil(n: f64) -> f64;
+    pure fn cos(n: f64) -> f64;
+    pure fn cosh(n: f64) -> f64;
+    pure fn exp(n: f64) -> f64;
+    #[link_name="fabs"] pure fn abs(n: f64) -> f64;
+    pure fn floor(n: f64) -> f64;
+    #[link_name="log"] pure fn ln(n: f64) -> f64;
+    #[link_name="log1p"] pure fn ln1p(n: f64) -> f64;
+    pure fn log10(n: f64) -> f64;
+    pure fn log2(n: f64) -> f64;
+    pure fn pow(n: f64, e: f64) -> f64;
+    pure fn sin(n: f64) -> f64;
+    pure fn sinh(n: f64) -> f64;
+    pure fn sqrt(n: f64) -> f64;
+    pure fn tan(n: f64) -> f64;
+    pure fn tanh(n: f64) -> f64;
 }
 
 #[link_name = "m"]
@@ -52,26 +52,26 @@ native mod f32 {
 
     // Alpabetically sorted by link_name
 
-    #[link_name="acosf"] fn acos(n: f32) -> f32;
-    #[link_name="asinf"] fn asin(n: f32) -> f32;
-    #[link_name="atanf"] fn atan(n: f32) -> f32;
-    #[link_name="atan2f"] fn atan2(a: f32, b: f32) -> f32;
-    #[link_name="ceilf"] fn ceil(n: f32) -> f32;
-    #[link_name="cosf"] fn cos(n: f32) -> f32;
-    #[link_name="coshf"] fn cosh(n: f32) -> f32;
-    #[link_name="expf"] fn exp(n: f32) -> f32;
-    #[link_name="fabsf"] fn abs(n: f32) -> f32;
-    #[link_name="floorf"] fn floor(n: f32) -> f32;
-    #[link_name="powf"] fn pow(n: f32, e: f32) -> f32;
-    #[link_name="sinf"] fn sin(n: f32) -> f32;
-    #[link_name="sinhf"] fn sinh(n: f32) -> f32;
-    #[link_name="sqrtf"] fn sqrt(n: f32) -> f32;
-    #[link_name="tanf"] fn tan(n: f32) -> f32;
-    #[link_name="tanhf"] fn tanh(n: f32) -> f32;
-    #[link_name="logf"] fn ln(n: f32) -> f32;
-    #[link_name="log1p"] fn ln1p(n: f64) -> f64;
-    #[link_name="log2f"] fn log2(n: f32) -> f32;
-    #[link_name="log10f"] fn log10(n: f32) -> f32;
+    #[link_name="acosf"] pure fn acos(n: f32) -> f32;
+    #[link_name="asinf"] pure fn asin(n: f32) -> f32;
+    #[link_name="atanf"] pure fn atan(n: f32) -> f32;
+    #[link_name="atan2f"] pure fn atan2(a: f32, b: f32) -> f32;
+    #[link_name="ceilf"] pure fn ceil(n: f32) -> f32;
+    #[link_name="cosf"] pure fn cos(n: f32) -> f32;
+    #[link_name="coshf"] pure fn cosh(n: f32) -> f32;
+    #[link_name="expf"] pure fn exp(n: f32) -> f32;
+    #[link_name="fabsf"] pure fn abs(n: f32) -> f32;
+    #[link_name="floorf"] pure fn floor(n: f32) -> f32;
+    #[link_name="powf"] pure fn pow(n: f32, e: f32) -> f32;
+    #[link_name="sinf"] pure fn sin(n: f32) -> f32;
+    #[link_name="sinhf"] pure fn sinh(n: f32) -> f32;
+    #[link_name="sqrtf"] pure fn sqrt(n: f32) -> f32;
+    #[link_name="tanf"] pure fn tan(n: f32) -> f32;
+    #[link_name="tanhf"] pure fn tanh(n: f32) -> f32;
+    #[link_name="logf"] pure fn ln(n: f32) -> f32;
+    #[link_name="log1p"] pure fn ln1p(n: f64) -> f64;
+    #[link_name="log2f"] pure fn log2(n: f32) -> f32;
+    #[link_name="log10f"] pure fn log10(n: f32) -> f32;
 }
 
 
@@ -189,7 +189,7 @@ Function: acos
 Returns the arccosine of an angle (measured in rad)
 */
 pure fn acos(x: float) -> float
-    { unsafe { c_float::acos(x as c_float) as float } }
+    { c_float::acos(x as c_float) as float }
 
 /*
 Function: asin
@@ -197,7 +197,7 @@ Function: asin
 Returns the arcsine of an angle (measured in rad)
 */
 pure fn asin(x: float) -> float
-    { unsafe { c_float::asin(x as c_float) as float } }
+    { c_float::asin(x as c_float) as float }
 
 /*
 Function: atan
@@ -205,7 +205,7 @@ Function: atan
 Returns the arctangents of an angle (measured in rad)
 */
 pure fn atan(x: float) -> float
-    { unsafe { c_float::atan(x as c_float) as float } }
+    { c_float::atan(x as c_float) as float }
 
 
 /*
@@ -214,7 +214,7 @@ Function: atan2
 Returns the arctangent of an angle (measured in rad)
 */
 pure fn atan2(y: float, x: float) -> float
-    { unsafe { c_float::atan2(y as c_float, x as c_float) as float } }
+    { c_float::atan2(y as c_float, x as c_float) as float }
 
 /*
 Function: ceil
@@ -224,7 +224,7 @@ Returns:
 The smallest integral value less than or equal to `n`
 */
 pure fn ceil(n: float) -> float
-    { unsafe { c_float::ceil(n as c_float) as float } }
+    { c_float::ceil(n as c_float) as float }
 
 /*
 Function: cos
@@ -232,7 +232,7 @@ Function: cos
 Returns the cosine of an angle `x` (measured in rad)
 */
 pure fn cos(x: float) -> float
-    { unsafe { c_float::cos(x as c_float) as float } }
+    { c_float::cos(x as c_float) as float }
 
 /*
 Function: cosh
@@ -241,7 +241,7 @@ Returns the hyperbolic cosine of `x`
 
 */
 pure fn cosh(x: float) -> float
-    { unsafe { c_float::cosh(x as c_float) as float } }
+    { c_float::cosh(x as c_float) as float }
 
 
 /*
@@ -252,7 +252,7 @@ Returns:
 e to the power of `n*
 */
 pure fn exp(n: float) -> float
-    { unsafe { c_float::exp(n as c_float) as float } }
+    { c_float::exp(n as c_float) as float }
 
 /*
 Function: abs
@@ -263,7 +263,7 @@ The absolute value of  `n`
 
 */
 pure fn abs(n: float) -> float
-    { unsafe { c_float::abs(n as c_float) as float } }
+    { c_float::abs(n as c_float) as float }
 
 /*
 Function: floor
@@ -273,7 +273,7 @@ Returns:
 The largest integral value less than or equal to `n`
 */
 pure fn floor(n: float) -> float
-    { unsafe { c_float::floor(n as c_float) as float } }
+    { c_float::floor(n as c_float) as float }
 
 /*
 Function: ln
@@ -281,7 +281,7 @@ Function: ln
 Returns the natural logaritm of `n`
 */
 pure fn ln(n: float) -> float
-    { unsafe { c_float::ln(n as c_float) as float } }
+    { c_float::ln(n as c_float) as float }
 
 /*
 Function: ln1p
@@ -290,7 +290,7 @@ Returns the natural logarithm of `1+n` accurately,
 even for very small values of `n`
 */
 pure fn ln1p(n: float) -> float
-    { unsafe { c_float::ln1p(n as c_float) as float } }
+    { c_float::ln1p(n as c_float) as float }
 
 /*
 Function: log10
@@ -298,7 +298,7 @@ Function: log10
 Returns the logarithm to base 10 of `n`
 */
 pure fn log10(n: float) -> float
-    { unsafe { c_float::log10(n as c_float) as float } }
+    { c_float::log10(n as c_float) as float }
 
 /*
 Function: log2
@@ -306,13 +306,13 @@ Function: log2
 Returns the logarithm to base 2 of `n`
 */
 pure fn log2(n: float) -> float
-    { unsafe { c_float::log2(n as c_float) as float } }
+    { c_float::log2(n as c_float) as float }
 
 /*
 Function: pow
 */
 pure fn pow(v: float, e: float) -> float
-    { unsafe { c_float::pow(v as c_float, e as c_float) as float } }
+    { c_float::pow(v as c_float, e as c_float) as float }
 
 
 /*
@@ -321,7 +321,7 @@ Function: sin
 Returns the sine of an angle `x` (measured in rad)
 */
 pure fn sin(x: float) -> float
-    { unsafe { c_float::sin(x as c_float) as float } }
+    { c_float::sin(x as c_float) as float }
 
 /*
 Function: sinh
@@ -329,7 +329,7 @@ Function: sinh
 Returns the hyperbolic sine of an angle `x` (measured in rad)
 */
 pure fn sinh(x: float) -> float
-    { unsafe { c_float::sinh(x as c_float) as float } }
+    { c_float::sinh(x as c_float) as float }
 
 /*
 Function: sqrt
@@ -337,7 +337,7 @@ Function: sqrt
 Returns the square root of `x`
 */
 pure fn sqrt(x: float) -> float
-    { unsafe { c_float::sqrt(x as c_float) as float } }
+    { c_float::sqrt(x as c_float) as float }
 
 /*
 Function: tan
@@ -346,7 +346,7 @@ Returns the tangent of an angle `x` (measured in rad)
 
 */
 pure fn tan(x: float) -> float
-    { unsafe { c_float::tan(x as c_float) as float } }
+    { c_float::tan(x as c_float) as float }
 
 /*
 Function: tanh
@@ -355,7 +355,7 @@ Returns the hyperbolic tangent of an angle `x` (measured in rad)
 
 */
 pure fn tanh(x: float) -> float
-    { unsafe { c_float::tanh(x as c_float) as float } }
+    { c_float::tanh(x as c_float) as float }
 
 
 

From 212a84251003fcb4b21e3c32ccbd49943e5dce69 Mon Sep 17 00:00:00 2001
From: Stefan Plantikow <stefan.plantikow@googlemail.com>
Date: Wed, 23 Nov 2011 01:39:17 +0100
Subject: [PATCH 3/5] std: added missing calls to math; covers C95 completely
 now, includes tests

---
 src/lib/math.rs          | 133 ++++++++++++++++++----
 src/test/stdtest/math.rs | 234 +++++++++++++++++++++++++++++++++++++--
 2 files changed, 336 insertions(+), 31 deletions(-)

diff --git a/src/lib/math.rs b/src/lib/math.rs
index 060d0b1cbb341..c870392e6b606 100644
--- a/src/lib/math.rs
+++ b/src/lib/math.rs
@@ -5,16 +5,18 @@ export min, max;
 
 export f32, f64;
 
-// Currently this module supports from -lmath
-// C95 - frexp - ldexp - fmod - modf + log2 + log1p
+// Currently this module supports from -lmath:
+// C95 + log2 + log1p + trunc + round + rint
 
 export
-    acos, asin, atan, atan2, ceil, cos, cosh, exp, abs, floor,
-    ln, ln1p, log10, log2, pow, sin, sinh, sqrt, tan, tanh;
+    acos, asin, atan, atan2, ceil, cos, cosh, exp, abs, floor, fmod, frexp,
+    ldexp, ln, ln1p, log10, log2, modf, rint, round, pow, sin, sinh, sqrt,
+    tan, tanh, trunc;
 
 // These two must match in width according to architecture
 
 import ctypes::c_float;
+import ctypes::c_int;
 import c_float = f64;
 
 
@@ -34,16 +36,23 @@ native mod f64 {
     pure fn exp(n: f64) -> f64;
     #[link_name="fabs"] pure fn abs(n: f64) -> f64;
     pure fn floor(n: f64) -> f64;
+    pure fn fmod(x: f64, y: f64) -> f64;
+    pure fn frexp(n: f64, &value: c_int) -> f64;
+    pure fn ldexp(x: f64, n: c_int) -> f64;
     #[link_name="log"] pure fn ln(n: f64) -> f64;
     #[link_name="log1p"] pure fn ln1p(n: f64) -> f64;
     pure fn log10(n: f64) -> f64;
     pure fn log2(n: f64) -> f64;
+    pure fn modf(n: f64, &iptr: f64) -> f64;
     pure fn pow(n: f64, e: f64) -> f64;
+    pure fn rint(n: f64) -> f64;
+    pure fn round(n: f64) -> f64;
     pure fn sin(n: f64) -> f64;
     pure fn sinh(n: f64) -> f64;
     pure fn sqrt(n: f64) -> f64;
     pure fn tan(n: f64) -> f64;
     pure fn tanh(n: f64) -> f64;
+    pure fn trunc(n: f64) -> f64;
 }
 
 #[link_name = "m"]
@@ -62,19 +71,25 @@ native mod f32 {
     #[link_name="expf"] pure fn exp(n: f32) -> f32;
     #[link_name="fabsf"] pure fn abs(n: f32) -> f32;
     #[link_name="floorf"] pure fn floor(n: f32) -> f32;
+    #[link_name="frexpf"] pure fn frexp(n: f64, &value: c_int) -> f32;
+    #[link_name="fmodf"] pure fn fmod(x: f32, y: f32) -> f32;
+    #[link_name="ldexpf"] pure fn ldexp(x: f32, n: c_int) -> f32;
+    #[link_name="logf"] pure fn ln(n: f32) -> f32;
+    #[link_name="log1p"] pure fn ln1p(n: f64) -> f64;
+    #[link_name="log2f"] pure fn log2(n: f32) -> f32;
+    #[link_name="log10f"] pure fn log10(n: f32) -> f32;
+    #[link_name="modff"] pure fn modf(n: f32, &iptr: f32) -> f32;
     #[link_name="powf"] pure fn pow(n: f32, e: f32) -> f32;
+    #[link_name="rintf"] pure fn rint(n: f32) -> f32;
+    #[link_name="roundf"] pure fn round(n: f32) -> f32;
     #[link_name="sinf"] pure fn sin(n: f32) -> f32;
     #[link_name="sinhf"] pure fn sinh(n: f32) -> f32;
     #[link_name="sqrtf"] pure fn sqrt(n: f32) -> f32;
     #[link_name="tanf"] pure fn tan(n: f32) -> f32;
     #[link_name="tanhf"] pure fn tanh(n: f32) -> f32;
-    #[link_name="logf"] pure fn ln(n: f32) -> f32;
-    #[link_name="log1p"] pure fn ln1p(n: f64) -> f64;
-    #[link_name="log2f"] pure fn log2(n: f32) -> f32;
-    #[link_name="log10f"] pure fn log10(n: f32) -> f32;
+    #[link_name="truncf"] pure fn trunc(n: f32) -> f32;
 }
 
-
 mod consts {
     /*
     Const: pi
@@ -219,9 +234,7 @@ pure fn atan2(y: float, x: float) -> float
 /*
 Function: ceil
 
-Returns:
-
-The smallest integral value less than or equal to `n`
+Returns the smallest integral value less than or equal to `n`
 */
 pure fn ceil(n: float) -> float
     { c_float::ceil(n as c_float) as float }
@@ -247,9 +260,7 @@ pure fn cosh(x: float) -> float
 /*
 Function: exp
 
-Returns:
-
-e to the power of `n*
+Returns `consts::e` to the power of `n*
 */
 pure fn exp(n: float) -> float
     { c_float::exp(n as c_float) as float }
@@ -257,10 +268,7 @@ pure fn exp(n: float) -> float
 /*
 Function: abs
 
-Returns:
-
-The absolute value of  `n`
-
+Returns the absolute value of  `n`
 */
 pure fn abs(n: float) -> float
     { c_float::abs(n as c_float) as float }
@@ -268,13 +276,19 @@ pure fn abs(n: float) -> float
 /*
 Function: floor
 
-Returns:
-
-The largest integral value less than or equal to `n`
+Returns the largest integral value less than or equal to `n`
 */
 pure fn floor(n: float) -> float
     { c_float::floor(n as c_float) as float }
 
+/*
+Function: fmod
+
+Returns the floating-point remainder of `x/y`
+*/
+pure fn fmod(x: float, y: float) -> float
+    { c_float::fmod(x as c_float, y as c_float) as float }
+
 /*
 Function: ln
 
@@ -283,6 +297,14 @@ Returns the natural logaritm of `n`
 pure fn ln(n: float) -> float
     { c_float::ln(n as c_float) as float }
 
+/*
+Function: ldexp
+
+Returns `x` multiplied by 2 to the power of `n`
+*/
+pure fn ldexp(n: float, i: int) -> float
+    { c_float::ldexp(n as c_float, i as c_int) as float }
+
 /*
 Function: ln1p
 
@@ -308,6 +330,45 @@ Returns the logarithm to base 2 of `n`
 pure fn log2(n: float) -> float
     { c_float::log2(n as c_float) as float }
 
+
+/*
+Function: modf
+
+Breaks `n` into integral and fractional parts such that both
+have the same sign as `n`
+
+The integral part is stored in `iptr`.
+
+Returns:
+
+The fractional part of `n`
+*/
+pure fn modf(n: float, &iptr: float) -> float {
+    unchecked {
+        let f = iptr as c_float;
+        let r = c_float::modf(n as c_float, f) as float;
+        iptr  = f as float;
+        ret r;
+    }
+}
+
+/*
+Function: frexp
+
+Breaks `n` into a normalized fraction and an integral power of 2
+
+The inegral part is stored in iptr.
+
+The functions return a number x such that x has a magnitude in the interval
+[1/2, 1) or 0, and `n == x*(2 to the power of exp)`.
+
+Returns:
+
+The fractional part of `n`
+*/
+pure fn frexp(n: float, &exp: c_int) -> float
+    { c_float::frexp(n as c_float, exp) as float }
+
 /*
 Function: pow
 */
@@ -315,6 +376,25 @@ pure fn pow(v: float, e: float) -> float
     { c_float::pow(v as c_float, e as c_float) as float }
 
 
+/*
+Function: rint
+
+Returns the integral value nearest to `x` (according to the
+prevailing rounding mode) in floating-point format
+*/
+pure fn rint(x: float) -> float
+    { c_float::rint(x as c_float) as float }
+
+/*
+Function: round
+
+
+Return the integral value nearest to `x` rounding half-way
+cases away from zero, regardless of the current rounding direction.
+*/
+pure fn round(x: float) -> float
+    { c_float::round(x as c_float) as float }
+
 /*
 Function: sin
 
@@ -357,6 +437,15 @@ Returns the hyperbolic tangent of an angle `x` (measured in rad)
 pure fn tanh(x: float) -> float
     { c_float::tanh(x as c_float) as float }
 
+/*
+Function: trunc
+
+Returns the integral value nearest to but no larger in magnitude than `x`
+
+*/
+pure fn trunc(x: float) -> float
+    { c_float::trunc(x as c_float) as float }
+
 
 
 
diff --git a/src/test/stdtest/math.rs b/src/test/stdtest/math.rs
index 53d93ae3077ac..c7b3c45bd6b19 100644
--- a/src/test/stdtest/math.rs
+++ b/src/test/stdtest/math.rs
@@ -1,14 +1,8 @@
 use std;
+
 import std::math::*;
 import std::float;
-
-#[test]
-fn test_sqrt() {
-    assert sqrt(9.0) == 3.0;
-    assert sqrt(4.0) == 2.0;
-    assert sqrt(1.0) == 1.0;
-    assert sqrt(0.0) == 0.0;
-}
+import c_int = std::ctypes::c_int;
 
 #[test]
 fn test_max_min() {
@@ -20,6 +14,229 @@ fn test_max_min() {
     assert min(0.0, 1.0) == 0.0;
 }
 
+// FIXME use macros to execute the tests below for all float types
+
+#[test]
+fn test_trig() {
+    assert sin(0.0) == 0.0;
+    assert sin(-0.0) == 0.0;
+    assert float::isNaN(sin(float::infinity));
+    assert float::isNaN(sin(float::neg_infinity));
+
+    assert cos(0.0) == 1.0;
+    assert cos(-0.0) == 1.0;
+    assert float::isNaN(cos(float::infinity));
+    assert float::isNaN(cos(float::neg_infinity));
+
+    assert tan(0.0) == 0.0;
+    assert tan(-0.0) == 0.0;;
+    assert float::isNaN(tan(float::infinity));
+    assert float::isNaN(tan(float::neg_infinity));
+}
+
+#[test]
+fn test_inv_trig() {
+    assert asin(0.0) == 0.0;
+    assert asin(-0.0) == -0.0;
+    assert float::isNaN(asin(1.1));
+    assert float::isNaN(asin(-1.1));
+
+    assert acos(1.0) == 0.0;
+    assert float::isNaN(acos(1.1));
+    assert float::isNaN(acos(-1.1));
+
+    assert atan(0.0) == 0.0;
+    assert atan(-0.0) == 0.0;
+    assert atan(float::infinity) == consts::frac_pi_2;
+    assert atan(float::neg_infinity) == - consts::frac_pi_2;
+
+    assert atan2(0.0, -0.0) == consts::pi;
+    assert atan2(-0.0, -0.0) == -consts::pi;
+
+    assert atan2(0.0, 0.0) == 0.0;
+    assert atan2(-0.0, 0.0) == -0.0;
+
+    assert atan2(0.0, -1.0) == consts::pi;
+    assert atan2(-0.0, -1.0) == -consts::pi;
+
+    assert atan2(0.0, 1.0) == 0.0;
+    assert atan2(-0.0, 1.0) == -0.0;
+
+    assert atan2(1.0, 0.0) == consts::frac_pi_2;
+    assert atan2(1.0, -0.0) == consts::frac_pi_2;
+}
+
+#[test]
+fn test_pow() {
+    assert pow(2.0, 4.0) == 16.0;
+
+    assert pow(0.0, -3.0) == float::infinity;
+    assert pow(-0.0, -3.0) == float::neg_infinity;
+
+    assert pow(0.0, -4.0) == float::infinity;
+    assert pow(-0.0, -4.0) == float::infinity;
+
+    assert pow(0.0, 3.0) == 0.0;
+    assert pow(-0.0, 3.0) == -0.0;
+    assert pow(0.0, 4.0) == 0.0;
+    assert pow(-0.0, 4.0) == 0.0;
+
+    assert pow(-1.0, float::infinity) == 1.0;
+    assert pow(-1.0, float::neg_infinity) == 1.0;
+
+    assert pow(1.0, 4.0) == 1.0;
+    assert pow(1.0, 0.0) == 1.0;
+    assert pow(1.0, -0.0) == 1.0;
+    assert pow(1.0, float::NaN) == 1.0;
+    assert pow(1.0, float::infinity) == 1.0;
+    assert pow(1.0, float::neg_infinity) == 1.0;
+    assert pow(1.0, -3.0) == 1.0;
+    assert pow(1.0, -4.0) == 1.0;
+
+    assert pow(4.0, 0.0) == 1.0;
+    assert pow(0.0, 0.0) == 1.0;
+    assert pow(-0.0, 0.0) == 1.0;
+    assert pow(float::NaN, 0.0) == 1.0;
+    assert pow(float::infinity, 0.0) == 1.0;
+    assert pow(float::neg_infinity, 0.0) == 1.0;
+    assert pow(-3.0, 0.0) == 1.0;
+    assert pow(-4.0, 0.0) == 1.0;
+
+    assert pow(4.0, -0.0) == 1.0;
+    assert pow(0.0, -0.0) == 1.0;
+    assert pow(-0.0, -0.0) == 1.0;
+    assert pow(float::NaN, -0.0) == 1.0;
+    assert pow(float::infinity, -0.0) == 1.0;
+    assert pow(float::neg_infinity, -0.0) == 1.0;
+    assert pow(-3.0, -0.0) == 1.0;
+    assert pow(-4.0, -0.0) == 1.0;
+
+    assert float::isNaN(pow(-1.0, -1.5));
+    assert float::isNaN(pow(-1.0, 1.5));
+
+    assert float::isNaN(pow(-1.2, -1.5));
+    assert float::isNaN(pow(-1.2, 1.5));
+
+    assert pow(0.5, float::neg_infinity) == float::infinity;
+    assert pow(-0.5, float::neg_infinity) == float::infinity;
+
+    assert pow(1.5, float::neg_infinity) == 0.0;
+    assert pow(-1.5, float::neg_infinity) == 0.0;
+
+    assert pow(0.5, float::infinity) == 0.0;
+    assert pow(-0.5, float::infinity) == 0.0;
+
+    assert pow(-1.5, float::infinity) == float::infinity;
+    assert pow(1.5, float::infinity) == float::infinity;
+
+    assert pow(float::neg_infinity, -3.0) == -0.0;
+    assert pow(float::neg_infinity, -4.0) == 0.0;
+
+    assert pow(float::neg_infinity, 3.0) == float::neg_infinity;
+    assert pow(float::neg_infinity, 4.0) == float::infinity;
+
+    assert pow(float::infinity, -16.0) == 0.0;
+    assert pow(float::infinity, 16.0) == float::infinity;
+}
+
+#[test]
+fn test_exp_and_mod() {
+    assert exp(0.0) == 1.0;
+    assert exp(-0.0) == 1.0;
+    assert exp(float::neg_infinity) == 0.0;
+    assert exp(float::infinity) == float::infinity;
+
+    let d1: c_int = 1 as c_int;
+    assert frexp(0.0, d1) == 0.0;
+    assert frexp(-0.0, d1) == 0.0;
+    assert frexp(float::infinity, d1) == float::infinity;
+    assert frexp(float::neg_infinity, d1) == float::neg_infinity;
+    assert float::isNaN(frexp(float::NaN, d1));
+
+    let d2: float = 1.0;
+    assert modf(float::infinity, d2) == 0.0;
+    assert modf(float::neg_infinity, d2) == -0.0;
+    assert float::isNaN(modf(float::NaN, d2));
+}
+
+#[test]
+fn test_round_and_abs() {
+    assert abs(0.0) == 0.0;
+    assert abs(-0.0) == 0.0;
+    assert abs(float::infinity) == float::infinity;
+    assert abs(float::neg_infinity) == float::infinity;
+
+    assert abs(-2.5) == 2.5;
+    assert abs(2.5) == 2.5;
+
+    assert ceil(0.0) == 0.0;
+    assert ceil(-0.0) == -0.0;
+    assert ceil(float::infinity) == float::infinity;
+    assert ceil(float::neg_infinity) == float::neg_infinity;
+
+    assert ceil(1.9) == 2.0;
+    assert ceil(-1.9) == -1.0;
+
+    assert floor(0.0) == 0.0;
+    assert floor(-0.0) == -0.0;
+    assert floor(float::infinity) == float::infinity;
+    assert floor(float::neg_infinity) == float::neg_infinity;
+
+    assert floor(1.9) == 1.0;
+    assert floor(-1.9) == -2.0;
+
+    assert trunc(0.0) == 0.0;
+    assert trunc(-0.0) == -0.0;
+    assert trunc(float::infinity) == float::infinity;
+    assert trunc(float::neg_infinity) == float::neg_infinity;
+
+    assert trunc(1.5) == 1.0;
+    assert trunc(1.2) == 1.0;
+    assert trunc(1.0) == 1.0;
+    assert trunc(1.9) == 1.0;
+    assert trunc(-1.5) == -1.0;
+    assert trunc(-1.2) == -1.0;
+    assert trunc(-1.0) == -1.0;
+    assert trunc(-1.9) == -1.0;
+
+    assert round(0.0) == 0.0;
+    assert round(-0.0) == -0.0;
+    assert round(float::infinity) == float::infinity;
+    assert round(float::neg_infinity) == float::neg_infinity;
+
+    assert rint(0.0) == 0.0;
+    assert rint(-0.0) == -0.0;
+    assert rint(float::infinity) == float::infinity;
+    assert rint(float::neg_infinity) == float::neg_infinity;
+}
+
+#[test]
+fn test_hyp_trig() {
+    assert sinh(0.0) == 0.0;
+    assert sinh(-0.0) == 0.0;
+    assert sinh(float::infinity) == float::infinity;
+    assert sinh(float::neg_infinity) == float::neg_infinity;
+
+    assert cosh(0.0) == 1.0;
+    assert cosh(-0.0) == 1.0;
+    assert cosh(float::infinity) == float::infinity;
+    assert cosh(float::neg_infinity) == float::infinity;
+
+    assert tanh(0.0) == 0.0;
+    assert tanh(-0.0) == 0.0;
+    assert tanh(float::infinity) == 1.0;
+    assert tanh(float::neg_infinity) == -1.0;
+}
+
+#[test]
+fn test_sqrt() {
+    assert sqrt(9.0) == 3.0;
+    assert sqrt(4.0) == 2.0;
+    assert sqrt(1.0) == 1.0;
+    assert sqrt(0.0) == 0.0;
+}
+
+
 #[test]
 fn test_angle() {
     fn angle(vec: (float, float)) -> float {
@@ -36,7 +253,6 @@ fn test_angle() {
 
 
 #[test]
-#[ignore]
 fn test_log_functions() {
     assert ln(1.0) == 0.0;
     assert log2(1.0) == 0.0;

From fa4ffd4cffe42a8e1855499727183ebce8660190 Mon Sep 17 00:00:00 2001
From: Stefan Plantikow <stefan.plantikow@googlemail.com>
Date: Wed, 23 Nov 2011 18:37:17 +0100
Subject: [PATCH 4/5] std: factored f32 and f64 out from math

---
 src/lib/cmath.rs         |  71 +++++++++++++++++++++++++++
 src/lib/f32.rs           | 102 +++++++++++++++++++++++++++++++++++++++
 src/lib/f64.rs           | 102 +++++++++++++++++++++++++++++++++++++++
 src/lib/math.rs          |  79 ++----------------------------
 src/lib/std.rc           |   6 ++-
 src/test/stdtest/math.rs |   6 ++-
 6 files changed, 289 insertions(+), 77 deletions(-)
 create mode 100644 src/lib/cmath.rs
 create mode 100644 src/lib/f32.rs
 create mode 100644 src/lib/f64.rs

diff --git a/src/lib/cmath.rs b/src/lib/cmath.rs
new file mode 100644
index 0000000000000..69ecbac3e9125
--- /dev/null
+++ b/src/lib/cmath.rs
@@ -0,0 +1,71 @@
+import ctypes::c_int;
+
+#[link_name = "m"]
+#[abi = "cdecl"]
+native mod f64 {
+
+    // Alpabetically sorted by link_name
+
+    pure fn acos(n: f64) -> f64;
+    pure fn asin(n: f64) -> f64;
+    pure fn atan(n: f64) -> f64;
+    pure fn atan2(a: f64, b: f64) -> f64;
+    pure fn ceil(n: f64) -> f64;
+    pure fn cos(n: f64) -> f64;
+    pure fn cosh(n: f64) -> f64;
+    pure fn exp(n: f64) -> f64;
+    #[link_name="fabs"] pure fn abs(n: f64) -> f64;
+    pure fn floor(n: f64) -> f64;
+    pure fn fmod(x: f64, y: f64) -> f64;
+    pure fn frexp(n: f64, &value: c_int) -> f64;
+    pure fn ldexp(x: f64, n: c_int) -> f64;
+    #[link_name="log"] pure fn ln(n: f64) -> f64;
+    #[link_name="log1p"] pure fn ln1p(n: f64) -> f64;
+    pure fn log10(n: f64) -> f64;
+    pure fn log2(n: f64) -> f64;
+    pure fn modf(n: f64, &iptr: f64) -> f64;
+    pure fn pow(n: f64, e: f64) -> f64;
+    pure fn rint(n: f64) -> f64;
+    pure fn round(n: f64) -> f64;
+    pure fn sin(n: f64) -> f64;
+    pure fn sinh(n: f64) -> f64;
+    pure fn sqrt(n: f64) -> f64;
+    pure fn tan(n: f64) -> f64;
+    pure fn tanh(n: f64) -> f64;
+    pure fn trunc(n: f64) -> f64;
+}
+
+#[link_name = "m"]
+#[abi = "cdecl"]
+native mod f32 {
+
+    // Alpabetically sorted by link_name
+
+    #[link_name="acosf"] pure fn acos(n: f32) -> f32;
+    #[link_name="asinf"] pure fn asin(n: f32) -> f32;
+    #[link_name="atanf"] pure fn atan(n: f32) -> f32;
+    #[link_name="atan2f"] pure fn atan2(a: f32, b: f32) -> f32;
+    #[link_name="ceilf"] pure fn ceil(n: f32) -> f32;
+    #[link_name="cosf"] pure fn cos(n: f32) -> f32;
+    #[link_name="coshf"] pure fn cosh(n: f32) -> f32;
+    #[link_name="expf"] pure fn exp(n: f32) -> f32;
+    #[link_name="fabsf"] pure fn abs(n: f32) -> f32;
+    #[link_name="floorf"] pure fn floor(n: f32) -> f32;
+    #[link_name="frexpf"] pure fn frexp(n: f64, &value: c_int) -> f32;
+    #[link_name="fmodf"] pure fn fmod(x: f32, y: f32) -> f32;
+    #[link_name="ldexpf"] pure fn ldexp(x: f32, n: c_int) -> f32;
+    #[link_name="logf"] pure fn ln(n: f32) -> f32;
+    #[link_name="log1p"] pure fn ln1p(n: f64) -> f64;
+    #[link_name="log2f"] pure fn log2(n: f32) -> f32;
+    #[link_name="log10f"] pure fn log10(n: f32) -> f32;
+    #[link_name="modff"] pure fn modf(n: f32, &iptr: f32) -> f32;
+    #[link_name="powf"] pure fn pow(n: f32, e: f32) -> f32;
+    #[link_name="rintf"] pure fn rint(n: f32) -> f32;
+    #[link_name="roundf"] pure fn round(n: f32) -> f32;
+    #[link_name="sinf"] pure fn sin(n: f32) -> f32;
+    #[link_name="sinhf"] pure fn sinh(n: f32) -> f32;
+    #[link_name="sqrtf"] pure fn sqrt(n: f32) -> f32;
+    #[link_name="tanf"] pure fn tan(n: f32) -> f32;
+    #[link_name="tanhf"] pure fn tanh(n: f32) -> f32;
+    #[link_name="truncf"] pure fn trunc(n: f32) -> f32;
+}
diff --git a/src/lib/f32.rs b/src/lib/f32.rs
new file mode 100644
index 0000000000000..fad7cd1110be1
--- /dev/null
+++ b/src/lib/f32.rs
@@ -0,0 +1,102 @@
+import cmath::f32::*;
+
+export
+    acos, asin, atan, atan2, ceil, cos, cosh, exp, abs, floor, fmod,
+    frexp, ldexp, ln, ln1p, log10, log2, modf, rint, round, pow, sin,
+    sinh, sqrt, tan, tanh, trunc;
+
+export consts;
+
+mod consts {
+
+    /*
+    Const: pi
+
+    Archimedes' constant
+    */
+    const pi: f32 = 3.14159265358979323846264338327950288f32;
+
+    /*
+    Const: frac_pi_2
+
+    pi/2.0
+    */
+    const frac_pi_2: f32 = 1.57079632679489661923132169163975144f32;
+
+    /*
+    Const: frac_pi_4
+
+    pi/4.0
+    */
+    const frac_pi_4: f32 = 0.785398163397448309615660845819875721f32;
+
+    /*
+    Const: frac_1_pi
+
+    1.0/pi
+    */
+    const frac_1_pi: f32 = 0.318309886183790671537767526745028724f32;
+
+    /*
+    Const: frac_2_pi
+
+    2.0/pi
+    */
+    const frac_2_pi: f32 = 0.636619772367581343075535053490057448f32;
+
+    /*
+    Const: frac_2_sqrtpi
+
+    2.0/sqrt(pi)
+    */
+    const frac_2_sqrtpi: f32 = 1.12837916709551257389615890312154517f32;
+
+    /*
+    Const: sqrt2
+
+    sqrt(2.0)
+    */
+    const sqrt2: f32 = 1.41421356237309504880168872420969808f32;
+
+    /*
+    Const: frac_1_sqrt2
+
+    1.0/sqrt(2.0)
+    */
+    const frac_1_sqrt2: f32 = 0.707106781186547524400844362104849039f32;
+
+    /*
+    Const: e
+
+    Euler's number
+    */
+    const e: f32 = 2.71828182845904523536028747135266250f32;
+
+    /*
+    Const: log2_e
+
+    log2(e)
+    */
+    const log2_e: f32 = 1.44269504088896340735992468100189214f32;
+
+    /*
+    Const: log10_e
+
+    log10(e)
+    */
+    const log10_e: f32 = 0.434294481903251827651128918916605082f32;
+
+    /*
+    Const: ln_2
+
+    ln(2.0)
+    */
+    const ln_2: f32 = 0.693147180559945309417232121458176568f32;
+
+    /*
+    Const: ln_10
+
+    ln(10.0)
+    */
+    const ln_10: f32 = 2.30258509299404568401799145468436421f32;
+}
\ No newline at end of file
diff --git a/src/lib/f64.rs b/src/lib/f64.rs
new file mode 100644
index 0000000000000..b94e3dfe5db78
--- /dev/null
+++ b/src/lib/f64.rs
@@ -0,0 +1,102 @@
+import cmath::f64::*;
+
+export
+    acos, asin, atan, atan2, ceil, cos, cosh, exp, abs, floor, fmod,
+    frexp, ldexp, ln, ln1p, log10, log2, modf, rint, round, pow, sin,
+    sinh, sqrt, tan, tanh, trunc;
+
+export consts;
+
+mod consts {
+
+    /*
+    Const: pi
+
+    Archimedes' constant
+    */
+    const pi: f64 = 3.14159265358979323846264338327950288f64;
+
+    /*
+    Const: frac_pi_2
+
+    pi/2.0
+    */
+    const frac_pi_2: f64 = 1.57079632679489661923132169163975144f64;
+
+    /*
+    Const: frac_pi_4
+
+    pi/4.0
+    */
+    const frac_pi_4: f64 = 0.785398163397448309615660845819875721f64;
+
+    /*
+    Const: frac_1_pi
+
+    1.0/pi
+    */
+    const frac_1_pi: f64 = 0.318309886183790671537767526745028724f64;
+
+    /*
+    Const: frac_2_pi
+
+    2.0/pi
+    */
+    const frac_2_pi: f64 = 0.636619772367581343075535053490057448f64;
+
+    /*
+    Const: frac_2_sqrtpi
+
+    2.0/sqrt(pi)
+    */
+    const frac_2_sqrtpi: f64 = 1.12837916709551257389615890312154517f64;
+
+    /*
+    Const: sqrt2
+
+    sqrt(2.0)
+    */
+    const sqrt2: f64 = 1.41421356237309504880168872420969808f64;
+
+    /*
+    Const: frac_1_sqrt2
+
+    1.0/sqrt(2.0)
+    */
+    const frac_1_sqrt2: f64 = 0.707106781186547524400844362104849039f64;
+
+    /*
+    Const: e
+
+    Euler's number
+    */
+    const e: f64 = 2.71828182845904523536028747135266250f64;
+
+    /*
+    Const: log2_e
+
+    log2(e)
+    */
+    const log2_e: f64 = 1.44269504088896340735992468100189214f64;
+
+    /*
+    Const: log10_e
+
+    log10(e)
+    */
+    const log10_e: f64 = 0.434294481903251827651128918916605082f64;
+
+    /*
+    Const: ln_2
+
+    ln(2.0)
+    */
+    const ln_2: f64 = 0.693147180559945309417232121458176568f64;
+
+    /*
+    Const: ln_10
+
+    ln(10.0)
+    */
+    const ln_10: f64 = 2.30258509299404568401799145468436421f64;
+}
\ No newline at end of file
diff --git a/src/lib/math.rs b/src/lib/math.rs
index c870392e6b606..c880217ce8da3 100644
--- a/src/lib/math.rs
+++ b/src/lib/math.rs
@@ -3,8 +3,6 @@
 export consts;
 export min, max;
 
-export f32, f64;
-
 // Currently this module supports from -lmath:
 // C95 + log2 + log1p + trunc + round + rint
 
@@ -19,77 +17,7 @@ import ctypes::c_float;
 import ctypes::c_int;
 import c_float = f64;
 
-
-#[link_name = "m"]
-#[abi = "cdecl"]
-native mod f64 {
-
-    // Alpabetically sorted by link_name
-
-    pure fn acos(n: f64) -> f64;
-    pure fn asin(n: f64) -> f64;
-    pure fn atan(n: f64) -> f64;
-    pure fn atan2(a: f64, b: f64) -> f64;
-    pure fn ceil(n: f64) -> f64;
-    pure fn cos(n: f64) -> f64;
-    pure fn cosh(n: f64) -> f64;
-    pure fn exp(n: f64) -> f64;
-    #[link_name="fabs"] pure fn abs(n: f64) -> f64;
-    pure fn floor(n: f64) -> f64;
-    pure fn fmod(x: f64, y: f64) -> f64;
-    pure fn frexp(n: f64, &value: c_int) -> f64;
-    pure fn ldexp(x: f64, n: c_int) -> f64;
-    #[link_name="log"] pure fn ln(n: f64) -> f64;
-    #[link_name="log1p"] pure fn ln1p(n: f64) -> f64;
-    pure fn log10(n: f64) -> f64;
-    pure fn log2(n: f64) -> f64;
-    pure fn modf(n: f64, &iptr: f64) -> f64;
-    pure fn pow(n: f64, e: f64) -> f64;
-    pure fn rint(n: f64) -> f64;
-    pure fn round(n: f64) -> f64;
-    pure fn sin(n: f64) -> f64;
-    pure fn sinh(n: f64) -> f64;
-    pure fn sqrt(n: f64) -> f64;
-    pure fn tan(n: f64) -> f64;
-    pure fn tanh(n: f64) -> f64;
-    pure fn trunc(n: f64) -> f64;
-}
-
-#[link_name = "m"]
-#[abi = "cdecl"]
-native mod f32 {
-
-    // Alpabetically sorted by link_name
-
-    #[link_name="acosf"] pure fn acos(n: f32) -> f32;
-    #[link_name="asinf"] pure fn asin(n: f32) -> f32;
-    #[link_name="atanf"] pure fn atan(n: f32) -> f32;
-    #[link_name="atan2f"] pure fn atan2(a: f32, b: f32) -> f32;
-    #[link_name="ceilf"] pure fn ceil(n: f32) -> f32;
-    #[link_name="cosf"] pure fn cos(n: f32) -> f32;
-    #[link_name="coshf"] pure fn cosh(n: f32) -> f32;
-    #[link_name="expf"] pure fn exp(n: f32) -> f32;
-    #[link_name="fabsf"] pure fn abs(n: f32) -> f32;
-    #[link_name="floorf"] pure fn floor(n: f32) -> f32;
-    #[link_name="frexpf"] pure fn frexp(n: f64, &value: c_int) -> f32;
-    #[link_name="fmodf"] pure fn fmod(x: f32, y: f32) -> f32;
-    #[link_name="ldexpf"] pure fn ldexp(x: f32, n: c_int) -> f32;
-    #[link_name="logf"] pure fn ln(n: f32) -> f32;
-    #[link_name="log1p"] pure fn ln1p(n: f64) -> f64;
-    #[link_name="log2f"] pure fn log2(n: f32) -> f32;
-    #[link_name="log10f"] pure fn log10(n: f32) -> f32;
-    #[link_name="modff"] pure fn modf(n: f32, &iptr: f32) -> f32;
-    #[link_name="powf"] pure fn pow(n: f32, e: f32) -> f32;
-    #[link_name="rintf"] pure fn rint(n: f32) -> f32;
-    #[link_name="roundf"] pure fn round(n: f32) -> f32;
-    #[link_name="sinf"] pure fn sin(n: f32) -> f32;
-    #[link_name="sinhf"] pure fn sinh(n: f32) -> f32;
-    #[link_name="sqrtf"] pure fn sqrt(n: f32) -> f32;
-    #[link_name="tanf"] pure fn tan(n: f32) -> f32;
-    #[link_name="tanhf"] pure fn tanh(n: f32) -> f32;
-    #[link_name="truncf"] pure fn trunc(n: f32) -> f32;
-}
-
+// FIXME replace with redirect to c_float::consts::FOO as soon as it works
 mod consts {
     /*
     Const: pi
@@ -181,9 +109,12 @@ mod consts {
     ln(10.0)
     */
     const ln_10: float = 2.30258509299404568401799145468436421;
-
 }
 
+
+// FIXME min/max type specialize via libm when overloading works
+// (in theory fmax/fmin, fmaxf, fminf /should/ be faster)
+
 /*
 Function: min
 
diff --git a/src/lib/std.rc b/src/lib/std.rc
index 87184d5e9055b..0c0737dcbdf88 100644
--- a/src/lib/std.rc
+++ b/src/lib/std.rc
@@ -7,7 +7,8 @@
 #[license = "BSD"];
 
 
-export box, char, float, int, str, ptr, uint, u8, u32, u64, vec, bool;
+export box, char, float, f32, f64, int, str, ptr;
+export  uint, u8, u32, u64, vec, bool;
 export comm, fs, io, net, run, sys, task;
 export ctypes, either, option, result, four, tri, util;
 export bitv, deque, fun_treemap, list, map, smallintmap, sort, treemap, ufind;
@@ -23,6 +24,8 @@ export generic_os, os, os_fs;
 mod box;
 mod char;
 mod float;
+mod f32;
+mod f64;
 mod int;
 mod str;
 mod ptr;
@@ -48,6 +51,7 @@ mod task;
 // Utility modules
 
 mod ctypes;
+mod cmath; /* unexported */
 mod either;
 mod option;
 mod result;
diff --git a/src/test/stdtest/math.rs b/src/test/stdtest/math.rs
index c7b3c45bd6b19..458d3e1a9056b 100644
--- a/src/test/stdtest/math.rs
+++ b/src/test/stdtest/math.rs
@@ -258,11 +258,13 @@ fn test_log_functions() {
     assert log2(1.0) == 0.0;
     assert log10(1.0) == 0.0;
 
-    assert ln(consts::e) == 1.0;
+    // FIXME remove round-up due to valgrind weirdness
+    assert ceil(ln(consts::e)) /* ln(e) == 0.999.. under valgrind */
     assert log2(2.0) == 1.0;
     assert log10(10.0) == 1.0;
 
-    assert ln(consts::e*consts::e*consts::e*consts::e) == 4.0;
+    // FIXME remove round-up due to valgrind weirdness
+    assert ceil(ln(consts::e*consts::e*consts::e*consts::e)) == 4.0;
     assert log2(256.0) == 8.0;
     assert log10(1000.0) == 3.0;
 

From bce7fef19f26032af8ff7c53b4049858d8b706f4 Mon Sep 17 00:00:00 2001
From: Stefan Plantikow <stefan.plantikow@googlemail.com>
Date: Thu, 24 Nov 2011 20:43:33 +0100
Subject: [PATCH 5/5] std: math: renaming and documentation fixes

---
 src/lib/math.rs                 |  9 +++++++--
 src/lib/{f32.rs => math_f32.rs} | 10 ++++++++++
 src/lib/{f64.rs => math_f64.rs} | 10 ++++++++++
 src/lib/std.rc                  | 11 ++++++-----
 src/test/stdtest/math.rs        |  3 ++-
 5 files changed, 35 insertions(+), 8 deletions(-)
 rename src/lib/{f32.rs => math_f32.rs} (90%)
 rename src/lib/{f64.rs => math_f64.rs} (90%)

diff --git a/src/lib/math.rs b/src/lib/math.rs
index c880217ce8da3..7b4308668b48a 100644
--- a/src/lib/math.rs
+++ b/src/lib/math.rs
@@ -1,4 +1,9 @@
-/* Module: math */
+/*
+
+Module: math
+
+Floating point operations and constants for `float`s
+*/
 
 export consts;
 export min, max;
@@ -15,7 +20,7 @@ export
 
 import ctypes::c_float;
 import ctypes::c_int;
-import c_float = f64;
+import c_float = math_f64;
 
 // FIXME replace with redirect to c_float::consts::FOO as soon as it works
 mod consts {
diff --git a/src/lib/f32.rs b/src/lib/math_f32.rs
similarity index 90%
rename from src/lib/f32.rs
rename to src/lib/math_f32.rs
index fad7cd1110be1..2172c9f8a99c1 100644
--- a/src/lib/f32.rs
+++ b/src/lib/math_f32.rs
@@ -1,3 +1,13 @@
+
+/*
+Module: math_f32
+
+Floating point operations and constants for `f32`
+
+This exposes the same operations as `math`, just for `f32` even though
+they do not show up in the docs right now!
+*/
+
 import cmath::f32::*;
 
 export
diff --git a/src/lib/f64.rs b/src/lib/math_f64.rs
similarity index 90%
rename from src/lib/f64.rs
rename to src/lib/math_f64.rs
index b94e3dfe5db78..639dc4a29b25f 100644
--- a/src/lib/f64.rs
+++ b/src/lib/math_f64.rs
@@ -1,3 +1,13 @@
+
+/*
+Module: math_f64
+
+Floating point operations and constants for `f64`s
+
+This exposes the same operations as `math`, just for `f64` even though
+they do not show up in the docs right now!
+*/
+
 import cmath::f64::*;
 
 export
diff --git a/src/lib/std.rc b/src/lib/std.rc
index 0c0737dcbdf88..7e958de0276c8 100644
--- a/src/lib/std.rc
+++ b/src/lib/std.rc
@@ -7,13 +7,14 @@
 #[license = "BSD"];
 
 
-export box, char, float, f32, f64, int, str, ptr;
-export  uint, u8, u32, u64, vec, bool;
+export box, char, float, int, str, ptr;
+export uint, u8, u32, u64, vec, bool;
 export comm, fs, io, net, run, sys, task;
 export ctypes, either, option, result, four, tri, util;
 export bitv, deque, fun_treemap, list, map, smallintmap, sort, treemap, ufind;
 export rope;
-export ebml, dbg, getopts, json, math, rand, sha1, term, time, unsafe;
+export math, math_f32, math_f64;
+export ebml, dbg, getopts, json, rand, sha1, term, time, unsafe;
 export extfmt, test;
 // FIXME: generic_os and os_fs shouldn't be exported
 export generic_os, os, os_fs;
@@ -24,8 +25,6 @@ export generic_os, os, os_fs;
 mod box;
 mod char;
 mod float;
-mod f32;
-mod f64;
 mod int;
 mod str;
 mod ptr;
@@ -81,6 +80,8 @@ mod dbg;
 mod getopts;
 mod json;
 mod math;
+mod math_f32;
+mod math_f64;
 mod rand;
 mod sha1;
 mod term;
diff --git a/src/test/stdtest/math.rs b/src/test/stdtest/math.rs
index 458d3e1a9056b..39b72e680782f 100644
--- a/src/test/stdtest/math.rs
+++ b/src/test/stdtest/math.rs
@@ -20,6 +20,7 @@ fn test_max_min() {
 fn test_trig() {
     assert sin(0.0) == 0.0;
     assert sin(-0.0) == 0.0;
+
     assert float::isNaN(sin(float::infinity));
     assert float::isNaN(sin(float::neg_infinity));
 
@@ -259,7 +260,7 @@ fn test_log_functions() {
     assert log10(1.0) == 0.0;
 
     // FIXME remove round-up due to valgrind weirdness
-    assert ceil(ln(consts::e)) /* ln(e) == 0.999.. under valgrind */
+    assert ceil(ln(consts::e)) == 1.0; /* ln(e) == 0.999.. under valgrind */
     assert log2(2.0) == 1.0;
     assert log10(10.0) == 1.0;