Skip to content

Disable download-rustc for library profile #143577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 7, 2025
Merged

Disable download-rustc for library profile #143577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9adbf62
Disable download-rustc for library profile
Noratrieb Jul 7, 2025
979d7b2
Add change tracker entry for disabling `download-rustc` temporarily
jieyouxu Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/bootstrap/defaults/bootstrap.library.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ lto = "off"
#
# If compiler-affecting directories are not modified, use precompiled rustc to speed up
# library development by skipping compiler builds.
download-rustc = "if-unchanged"
# FIXME: download-rustc is currently broken: https://github.com/rust-lang/rust/issues/142505
download-rustc = false

[llvm]
# Will download LLVM from CI if available on your platform.
Expand Down
5 changes: 5 additions & 0 deletions src/bootstrap/src/utils/change_tracker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -456,4 +456,9 @@ pub const CONFIG_CHANGE_HISTORY: &[ChangeInfo] = &[
severity: ChangeSeverity::Warning,
summary: "The default check stage has been changed to 1. It is no longer possible to `x check` with stage 0. All check commands have to be on stage 1+. Bootstrap tools can now also only be checked for the host target.",
},
ChangeInfo {
change_id: 143577,
severity: ChangeSeverity::Warning,
summary: "`download-rustc` has been temporarily disabled for the library profile due to implementation bugs (see #142505).",
},
];
Loading