From 42ae3dc45ef9639f20c43f05524032c9c44b314a Mon Sep 17 00:00:00 2001 From: JRegimbal Date: Thu, 9 Nov 2017 17:08:08 -0500 Subject: [PATCH 1/2] "Types/modules" in tab to "In name" "Types/modules" doesn't properly describe the results since it includes other things whose name matches the search term. --- src/librustdoc/html/static/main.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/librustdoc/html/static/main.js b/src/librustdoc/html/static/main.js index 8d0faf261f6c9..509bb3e4d1a55 100644 --- a/src/librustdoc/html/static/main.js +++ b/src/librustdoc/html/static/main.js @@ -41,7 +41,7 @@ // On the search screen, so you remain on the last tab you opened. // - // 0 for "Types/modules" + // 0 for "In name" // 1 for "As parameters" // 2 for "As return value" var currentTab = 0; @@ -1093,7 +1093,7 @@ output = '

Results for ' + escape(query.query) + (query.type ? ' (type: ' + escape(query.type) + ')' : '') + '

' + '
' + - makeTabHeader(0, "Types/modules", results['others'].length) + + makeTabHeader(0, "In name", results['others'].length) + makeTabHeader(1, "As parameters", results['in_args'].length) + makeTabHeader(2, "As return value", results['returned'].length) + '
'; From 41df62ce29bc73366c9c49ffaf8b1284d21d8000 Mon Sep 17 00:00:00 2001 From: JRegimbal Date: Tue, 5 Dec 2017 17:39:50 -0500 Subject: [PATCH 2/2] Changed tab names to those agreed upon. Tabs are "In Names", "In Parameters", and "In Return Types". --- src/librustdoc/html/static/main.js | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/librustdoc/html/static/main.js b/src/librustdoc/html/static/main.js index 509bb3e4d1a55..091297ddcd5a8 100644 --- a/src/librustdoc/html/static/main.js +++ b/src/librustdoc/html/static/main.js @@ -41,9 +41,9 @@ // On the search screen, so you remain on the last tab you opened. // - // 0 for "In name" - // 1 for "As parameters" - // 2 for "As return value" + // 0 for "In Names" + // 1 for "In Parameters" + // 2 for "In Return Types" var currentTab = 0; function hasClass(elem, className) { @@ -1093,9 +1093,9 @@ output = '

Results for ' + escape(query.query) + (query.type ? ' (type: ' + escape(query.type) + ')' : '') + '

' + '
' + - makeTabHeader(0, "In name", results['others'].length) + - makeTabHeader(1, "As parameters", results['in_args'].length) + - makeTabHeader(2, "As return value", results['returned'].length) + + makeTabHeader(0, "In Names", results['others'].length) + + makeTabHeader(1, "In Parameters", results['in_args'].length) + + makeTabHeader(2, "In Return Types", results['returned'].length) + '
'; output += addTab(results['others'], query);