From b29c783c81cb11944b775d8e02f5cd32a4f6dbd4 Mon Sep 17 00:00:00 2001 From: Ryan Levick Date: Fri, 10 Sep 2021 18:37:21 +0200 Subject: [PATCH 1/3] Add a significance threshold column --- site/src/api.rs | 1 + site/src/comparison.rs | 1 + site/static/compare.html | 4 ++++ 3 files changed, 6 insertions(+) diff --git a/site/src/api.rs b/site/src/api.rs index ce3873fbf..b71d1e92e 100644 --- a/site/src/api.rs +++ b/site/src/api.rs @@ -187,6 +187,7 @@ pub mod comparison { pub profile: String, pub scenario: String, pub is_significant: bool, + pub significance_threshold: f64, pub is_dodgy: bool, pub historical_statistics: Option>, pub statistics: (f64, f64), diff --git a/site/src/comparison.rs b/site/src/comparison.rs index 44de6b4fb..9a004a87a 100644 --- a/site/src/comparison.rs +++ b/site/src/comparison.rs @@ -114,6 +114,7 @@ pub async fn handle_compare( scenario: comparison.scenario.to_string(), is_dodgy: comparison.is_dodgy(), is_significant: comparison.is_significant(), + significance_threshold: comparison.signifcance_threshold() * 100.0, historical_statistics: comparison.variance.map(|v| v.data), statistics: comparison.results, }) diff --git a/site/static/compare.html b/site/static/compare.html index 73fd4a96c..4bf1c81a3 100644 --- a/site/static/compare.html +++ b/site/static/compare.html @@ -425,6 +425,9 @@

Comparing {{stat}} between { + + {{ run.significanceThreshold.toFixed(2) }}% + @@ -541,6 +544,7 @@

Comparing {{stat}} between { datumB, percent, isDodgy, + significanceThreshold: r.significance_threshold, isSignificant }); } From d14e10a0e615a4fce515d7168a612dec80ba7675 Mon Sep 17 00:00:00 2001 From: Ryan Levick Date: Fri, 10 Sep 2021 18:40:13 +0200 Subject: [PATCH 2/3] Make it a severity column --- site/static/compare.html | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/static/compare.html b/site/static/compare.html index 4bf1c81a3..c57457855 100644 --- a/site/static/compare.html +++ b/site/static/compare.html @@ -426,7 +426,7 @@

Comparing {{stat}} between { - {{ run.significanceThreshold.toFixed(2) }}% + {{ Math.abs(run.percent / run.significanceThreshold).toFixed(2) }}x From 69c0cd2483a1ad6ea609ef1ec4dd9440deea151a Mon Sep 17 00:00:00 2001 From: Ryan Levick Date: Mon, 13 Sep 2021 17:53:11 +0200 Subject: [PATCH 3/3] Add headers --- site/static/compare.html | 29 ++++++++++++++++++++++++++++- 1 file changed, 28 insertions(+), 1 deletion(-) diff --git a/site/static/compare.html b/site/static/compare.html index c57457855..46664a0e1 100644 --- a/site/static/compare.html +++ b/site/static/compare.html @@ -192,8 +192,15 @@ text-align: center; } - #benches th { + #benches tbody:first-child th { + text-align: center; + } + + #benches tbody:not(:first-child) th { border-right: dotted 1px; + } + + #benches th { text-align: left; word-break: break-word; width: 25%; @@ -401,6 +408,26 @@

Comparing {{stat}} between { + + + + + + + + + +
Name & ProfileScenario{{before}}{{after}}% Change + Significance Factor? + + How much a particular result is over the significance threshold. A factor of 2.50x + means + the result is 2.5 times over the significance threshold. You can see + here how the significance threshold is calculated. + + +