Extract Text from WASM page into Translation File #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
May 28, 2019
| wasm-production-cloudflare-quote = | ||
| We can compile Rust to WASM, and call it from Serverless functions woven into the very fabric of the Internet. That’s huge and I can’t wait to do more of it. | ||
| wasm-production-cloudflare-attribution = | ||
| – Steven Pack, <a href="{ $href }">Serverless Rust with Cloudflare Workers</a> |
There was a problem hiding this comment.
In the other pages the dash is not in the translation string
Manishearth
reviewed
May 28, 2019
| </a> | ||
|
|
||
| {{#text wasm-production-cloudflare-attribution}} | ||
| {{#textparam href}} |
There was a problem hiding this comment.
This can just be {{text wasm-production-cloudflare-attribution href="https://..."}}, textparam is for more complex stuff
Manishearth
reviewed
May 28, 2019
| wasm-production-mozilla-quote = | ||
| The JavaScript implementation [of the <code>source-map</code> library] has accumulated convoluted code in the name of performance, and we replaced it with idiomatic Rust. Rust does not force us to choose between clearly expressing intent and runtime performance. | ||
| wasm-production-mozilla-attribution = | ||
| – Nick Fitzgerald, <a href="{ $href }">Oxidizing Source Maps with Rust and WebAssembly</a> |
There was a problem hiding this comment.
We don't really need the hrefs here, but i guess it doesn't hurt. I should do this to the others.
|
I need to do some fixups but I'll merge first. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on #798
The webpage has been visually inspected side-by-side with the live site, and no differences have been found. I compared: