Merge in remaining i18n work #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parameterize {{baseurl}} in install.hbs file
Move Text from Embedded page into Translation Files
Use localization strings in networking page
Extract Text from WASM page into Translation File
Extract text from the 404 Page into Translation File
|
LGTM. One little question: can we whitelist the locales that are currently deployed/accessible in the main website? |
|
I'm going to be doing that, but on master |
|
(That needs to be done in tandem with #815) |
|
\o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @skade cc @eignnx
deployed at www-staging.rust-lang.org